Fix duplicate execution for typed overloads with identical signatures#156
Open
yotors wants to merge 2 commits intotrueagi-io:mainfrom
Open
Fix duplicate execution for typed overloads with identical signatures#156yotors wants to merge 2 commits intotrueagi-io:mainfrom
yotors wants to merge 2 commits intotrueagi-io:mainfrom
Conversation
yotors
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a dispatch bug where typed function calls could execute multiple times when the same type signature was declared more than once.
In typed dispatch, all type chains for a function were collected and converted into OR branches. If duplicate signatures existed, duplicate branches were generated, and each branch could succeed, causing repeated execution.
Example repro
Given:
(: bin (-> Number))
(= (bin) 1)
(: bin (-> Number))
(= (bin) 2)
!(bin)
Returns
1
2
1
2
Typed dispatch created two equivalent branches for the same signature, so both clauses could run.
Root cause
In translator.pl:308, typed dispatch used all matched type chains directly, without deduplicating identical signatures.
Fix
Deduplicate collected type chains before branch generation.
Generate typed branches only from unique type chains.
Keep existing behavior unchanged for genuinely different overload signatures.
Implemented in:
translator.pl:309
Behavior change
Before: duplicate identical type definitions could trigger duplicate function execution.
After: identical type chains collapse to a single dispatch branch, preventing duplicate execution.