Allow relative imports / functions in add/remove-atom#141
Allow relative imports / functions in add/remove-atom#141rTreutlein wants to merge 2 commits intomainfrom
Conversation
patham9
left a comment
There was a problem hiding this comment.
I do not yet grasp this PR. What does it add exactly? Needs a test I guess to show? :)
88bf9b3 to
0ba5536
Compare
|
There is a test for the relative imports and and i added one for the add/remove-atom change |
|
Translating the expression for the kb is not expensive in most cases it's just a symbol but now we support functions as well. |
|
Hm translating it again had significant overhead when I tried that on millions of items last time, maybe better to avoid it if possible? What does it have to do with relative imports anyways? |
|
@patham9 What do you mean translating it again before this change whatever was in the argument position for the space was just passe as the raw symbold so you could not do: And it doesn't really have anything to do with the imports to me it was just such a small clear improvment that i didn't bother with another PR. |
No description provided.