Merged
Conversation
…k head to head to check mork unification correctness. With a check for cycles added, they agree on the results.
Collaborator
|
Looks good except the unifiable change; ExprZipper should be seen as deprecated: the unifiable test should instead inline the unify method but use the coroutine version of apply with an Io::sink. |
Collaborator
Author
|
I made the change in the unification test, I get the same results. Which is good. I push the change, but I do feel that doing this inlining reveals that this pattern of inlining is done in a lot of parts of the code. I think this pull request can stop here, and we can address the occurs check on the cycles btreemaps at those 11 call sites in another pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a large test for unification, putting Prolog and MORK head to head to check MORK unification correctness.
With a check for cycles added, they agree on the results.
The test is done by running main in experiments/unification_test_laws.
A little bit of the complexity comes from the fact that, to have the test finish in a reasonable amount of time, they run fully in parallel; the Rust and Prolog code. On my machine it takes about 10 minutes per language to finish unifying. I've done my best to avoid over-optimizing however, as this isn't meant to be a benchmark.
This uses SWI Prolog, so one needs to install SWI Prolog to run the test.