Docker Build Infrastructure and PathMap Integration Updates#34
Open
kabirkbr wants to merge 4 commits intotrueagi-io:mainfrom
Open
Docker Build Infrastructure and PathMap Integration Updates#34kabirkbr wants to merge 4 commits intotrueagi-io:mainfrom
kabirkbr wants to merge 4 commits intotrueagi-io:mainfrom
Conversation
…g BytesTrieMap renaming to PathMap to correspond to latest changes in PathMap repo
…ust nightly inconsistencies with qemu; need to build on different machines;
Author
|
Hey @Adam-Vandervorst , i wanted to build docker images for mork inspired by your workshop yesterday; given that i did that on my tree, just went and issued a PR to your repo; welcome to consider or dismiss, as preferred; -- thanks; |
|
Hello @kabirkbr, is it possible to add support for the server branch and the MORK http server? |
Collaborator
|
@imlvts @TimVerhaegen any changes you'd like to see here before merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Docker containerization support for MORK and updates dependencies to align with recent PathMap repository changes.
Changes
Docker Support
docker/directory)Dockerfile: Multi-architecture support (linux/amd64, linux/arm64) with Ubuntu basebuild.sh: Comprehensive build script with platform selection, caching, and registry push optionsREADME.md: Documentation for Docker builds and usage.dockerignore: Optimized build context exclusionsKey features:
cargo build --releaseMulti-arch build limitation: Cross-platform builds using QEMU emulation do not work due to Rust nightly incompatibility with QEMU (segmentation faults). However, both supported architectures (amd64 and arm64) can be built successfully on their respective native machines.
Available pre-built images on Docker Hub:
kabirkbr/mork:amd64- Built on AMD64/Intel machinekabirkbr/mork:arm64- Built on ARM64/Apple Silicon machineDependency Updates
BytesTrieMaptoPathMapto match upstream repository renamingfreezedependency to workspace Cargo.toml (required dependency)frontend/src/main.rsto use new PathMap naming conventionsBuild Configuration
expr/Cargo.tomldocker/directory structureFiles Changed
Total: 7 files changed, 547 insertions(+), 5 deletions(-)
Usage
Build locally for your platform:
Use pre-built images from Docker Hub: