Implemented changes to the convolutional.py#19
Open
aprotsenko24 wants to merge 1 commit intomainfrom
Open
Conversation
…ng changes: 1) Removed redundant methods, e.g. forward_learning, forward_inference, as they are implemented by NodeBase, leaving only forward method 2) Tested the convolutional.py on mnist dataset and with additional test_convolutional.py file 3) Removed the @registry decorators, as the major refactoring of FabricPC 4) Added __init__ constructor for proper and direct installation 5) Added get_weight_fan_in method for proper muPC scaling support 6) Changed the unit test based on the implemented refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactored version of the convolutional.py implements the following changes: