Additional CI/CD workflow fixes (Issues #20, #28, #30)#31
Merged
Conversation
- Replace complex JSON output variable with file-based approach - Add comprehensive error handling with continue-on-error flags - Improve JSON validation and Python error handling - Add fallback mechanisms for missing data - Fix GitHub Actions output format issues that caused "Invalid format" errors Key fixes: - Save check runs JSON to file instead of passing through output variables - Add stderr redirection and null checks for all API calls - Implement graceful degradation when data is unavailable - Ensure all outputs have valid fallback values Resolves: #20
- Replace single-quoted heredoc with double-quoted to allow variable expansion - Generate timestamp in shell variable before using in heredoc - Fix both JSON status data and HTML dashboard timestamp - Add proper escaping for GitHub Actions variables Changes: - status.json now shows actual timestamp instead of shell command - HTML dashboard displays proper "Last updated" time - Fixed variable expansion in badges generation Before: Last updated: $( date -u '+%Y-%m-%d %H:%M UTC' ) After: Last updated: 2025-09-17 18:30 UTC Resolves: #28
- Fix YAML syntax error on line 200 in multiline Python script - Change python -c from double quotes to single quotes - Update internal Python quotes to avoid YAML conflicts - Rename workflow from "PR Feedback & Issue Reporting" to "PR Feedback" Technical changes: - Multiline Python script now uses proper YAML-safe quoting - All internal strings use double quotes to avoid conflicts - Workflow name simplified for better GitHub Actions display Before: python -c "...with single quotes inside..." After: python -c '...with double quotes inside...' Resolves: #30
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
🔍 PR Quality SummaryCI Status⚪ Tests: pending Metrics
Quality Checks
MCP Tools
🤖 Auto-generated by CI • Last updated: 2025-09-17 19:44 UTC |
Contributor
🔍 CI Quality Gates SummaryOverall Status: ✅ All Passed
🔗 Quick Links🛠️ Quick Fix Commands# Fix most issues automatically
ruff format .
ruff check . --fix
# Run tests locally
pytest tests/unit/ --cov=markitdown_mcp
# Check types
mypy markitdown_mcpLast updated: 2025-09-17 19:45:02 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains additional critical fixes for CI/CD workflows that resolve multiple issues with workflow validation and functionality.
Issues Fixed
Key Changes
1. PR Summary Workflow JSON Parsing Fix (Issue #20)
.github/workflows/pr-summary.yml2. Status Dashboard Timestamp Fix (Issue #28)
$( date -u '+%Y-%m-%d %H:%M UTC' )instead of actual time.github/workflows/status-dashboard.yml3. PR Feedback YAML Syntax Fix (Issue #30)
.github/workflows/pr-feedback.ymlTechnical Details
PR Summary Workflow
continue-on-errorflagsStatus Dashboard
PR Feedback Workflow
Validation
Test Plan
Breaking Changes
None - all changes are backward compatible improvements.
Additional Context
These fixes address critical workflow validation failures that were preventing proper CI/CD operation. All changes follow established patterns and maintain existing functionality while fixing syntax and parsing issues.