Skip to content

Fix CI/CD maintenance workflow triggering for PRs (Issue #14)#27

Merged
trsdn merged 2 commits into
mainfrom
ci-cd-maintenance
Sep 17, 2025
Merged

Fix CI/CD maintenance workflow triggering for PRs (Issue #14)#27
trsdn merged 2 commits into
mainfrom
ci-cd-maintenance

Conversation

@trsdn
Copy link
Copy Markdown
Owner

@trsdn trsdn commented Sep 17, 2025

Summary

  • Fix ci-cd-maintenance.yml workflow to trigger for pull requests from ci-cd-maintenance branch
  • Add branches-ignore exclusion to pr-summary.yml to prevent it running for ci-cd-maintenance PRs
  • Add conditional logic to ensure ci-cd-maintenance workflow only runs for appropriate branches

Changes Made

  1. ci-cd-maintenance.yml: Added pull_request trigger and conditional if statement
  2. pr-summary.yml: Added branches-ignore: [ci-cd-maintenance] exclusion

Test Plan

  • Create PR from ci-cd-maintenance branch
  • Verify ci-cd-maintenance.yml workflow triggers instead of regular CI workflows
  • Verify regular workflows are properly excluded
  • Confirm workflow runs successfully

Fixes

Resolves #14

Expected Behavior After Fix

  • PRs from ci-cd-maintenance branch should trigger the CI-CD Maintenance workflow
  • Regular CI workflows should be skipped for ci-cd-maintenance PRs
  • PR summary workflow should not run for ci-cd-maintenance PRs

- Distinguish between standard changes (coverage thresholds, bug fixes)
  and complex changes (new workflows, permissions)
- Standard changes can auto-merge after CI validation
- Complex changes require manual review for security implications
- Update workflow examples to reflect appropriate review level
- Add pull_request trigger to ci-cd-maintenance.yml workflow
- Add conditional check to only run when source branch is ci-cd-maintenance
- Add branches-ignore exclusion to pr-summary.yml workflow
- Ensures ci-cd-maintenance PRs use specialized workflow instead of regular CI

Fixes: #14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 17, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link
Copy Markdown
Contributor

🔍 CI Quality Gates Summary

Overall Status: ✅ All Passed

Check Status Details Action Required
🎨 Format ✅ Passed ruff format check None
🔧 Lint ✅ Passed ruff linting None
📝 Types ✅ Passed mypy type checking None
🧪 Tests ✅ Passed Unit tests None
📊 Coverage 80.5% Minimum: 80% None
🔌 MCP ✅ Valid Protocol compliance None
🔒 Security ✅ Clean Dependency audit None

🔗 Quick Links

🛠️ Quick Fix Commands

# Fix most issues automatically
ruff format .
ruff check . --fix

# Run tests locally
pytest tests/unit/ --cov=markitdown_mcp

# Check types
mypy markitdown_mcp

Last updated: 2025-09-17 17:37:24 UTC

@trsdn trsdn merged commit 6195010 into main Sep 17, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI/CD maintenance workflow not triggered for ci-cd-maintenance branch PRs

1 participant