Fix ruff formatting in markitdown_mcp/server.py on main branch#23
Merged
Conversation
Contributor
Author
|
@trsdn 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
- Fix string concatenation formatting issues - Merge unnecessarily split strings on lines 779, 784, 800, and 810 - Resolves CI Code Quality failures blocking all PRs Co-authored-by: trsdn <24534196+trsdn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ruff formatting in markitdown_mcp/server.py on main branch
Fix ruff formatting in markitdown_mcp/server.py on main branch
Sep 17, 2025
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
🔍 CI Quality Gates SummaryOverall Status: ✅ All Passed
🔗 Quick Links🛠️ Quick Fix Commands# Fix most issues automatically
ruff format .
ruff check . --fix
# Run tests locally
pytest tests/unit/ --cov=markitdown_mcp
# Check types
mypy markitdown_mcpLast updated: 2025-09-17 17:27:09 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file
markitdown_mcp/server.pyhad formatting issues that were causing all PRs to fail Code Quality checks, regardless of their content. The issue was caused by unnecessarily split string concatenations that ruff wanted to merge for better readability.Problem
String literals were split across multiple concatenated strings where they should have been single strings:
Solution
Applied
ruff formatto automatically fix the string concatenation formatting. The changes are minimal and surgical - only 4 lines were modified with no functional changes to the code.Impact
ruff format --check .)ruff check .)This was a critical blocking issue preventing any PR from passing CI, even those that didn't touch the affected file.
Fixes #21.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.