feat: clearer support for language prefixes #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If project have to use subdirectories (lang prefixes), like:
example.com/user- for Englishexample.com/de/user- for Germanexample.com/ko/user- for KoreanWe will face some problems:
if
/usernode is children of/node as well as children of/konode.When code will try to find a match for
/userby going through/node, it will slice/from/usersegment, so at the next iteration code will try to find a match foruserinstead of/user, thus will returnnullas result.So my proposal is to change literally one line of code, this shouldn't break anything, if i understand everything right.