-
Notifications
You must be signed in to change notification settings - Fork 5
[FIX] Remove Sentry from UIs #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| REACT_APP_GDS_API_ENDPOINT= | ||
| REACT_APP_GOOGLE_CLIENT_ID= | ||
| REACT_APP_GDS_IS_TESTNET= | ||
| REACT_APP_SENTRY_DSN= | ||
| REACT_APP_SENTRY_ENVIRONMENT= | ||
| REACT_APP_VERSION_NUMBER= | ||
| REACT_APP_GIT_REVISION= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,5 @@ | ||
| import * as Sentry from '@sentry/react'; | ||
| import { BrowserTracing } from '@sentry/tracing'; | ||
|
|
||
| import config from './config'; | ||
|
|
||
| const defaultTracingOrigins = ['localhost', /^\//]; | ||
|
|
||
| const initSentry = () => { | ||
| // ensure environment variables app version and git revision are set | ||
| if (!config.appVersion) { | ||
| // eslint-disable-next-line no-console | ||
| console.log('App version is not set in environment variables'); | ||
| } | ||
| if (!config.gitVersion) { | ||
| // eslint-disable-next-line no-console | ||
| console.log('Git revision is not set in environment variables'); | ||
| } | ||
| console.log(`AppVersion: ${config.appVersion || ''} - GitRevision: ${config.gitVersion || ''}`); // eslint-disable-line no-console | ||
|
|
||
| if (process.env.REACT_APP_SENTRY_DSN) { | ||
| let tracingOrigins = defaultTracingOrigins; | ||
| if (process.env.REACT_APP_GDS_API_ENDPOINT) { | ||
| const origin = new URL(process.env.REACT_APP_GDS_API_ENDPOINT); | ||
| tracingOrigins = [origin.host]; | ||
| } | ||
|
|
||
| const environment = process.env.REACT_APP_SENTRY_ENVIRONMENT | ||
| ? process.env.REACT_APP_SENTRY_ENVIRONMENT | ||
| : process.env.NODE_ENV; | ||
|
|
||
| Sentry.init({ | ||
| dsn: process.env.REACT_APP_SENTRY_DSN, | ||
| integrations: [new BrowserTracing({ tracingOrigins })], | ||
| environment, | ||
| tracesSampleRate: 1.0, | ||
| release: config?.appVersion || '', | ||
| // mute session expired errors | ||
| ignoreErrors: ['Session expired'], | ||
| }); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log('Sentry tracing initialized'); | ||
| } else { | ||
| // eslint-disable-next-line no-console | ||
| console.log('no Sentry configuration available'); | ||
| } | ||
| console.log('sentry is disabled in the GDS'); | ||
| }; | ||
|
|
||
| export default initSentry; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,5 @@ | ||
| import * as Sentry from '@sentry/react'; | ||
| import { BrowserTracing } from '@sentry/tracing'; | ||
| import { getAppVersionNumber } from '.'; | ||
|
|
||
| const defaultTracingOrigins = ['localhost', /^\//]; | ||
| const isProdEnv = process.env.NODE_ENV !== 'development'; | ||
| const initSentry = () => { | ||
| if (process.env.REACT_APP_SENTRY_DSN && isProdEnv) { | ||
| let tracingOrigins = defaultTracingOrigins; | ||
| if (process.env.REACT_APP_TRISA_BASE_URL) { | ||
| const origin = new URL(process.env.REACT_APP_TRISA_BASE_URL); | ||
| tracingOrigins = [origin.host]; | ||
| } | ||
|
|
||
| const environment = process.env.REACT_APP_SENTRY_ENVIRONMENT | ||
| ? process.env.REACT_APP_SENTRY_ENVIRONMENT | ||
| : process.env.NODE_ENV; | ||
|
|
||
| Sentry.init({ | ||
| dsn: process.env.REACT_APP_SENTRY_DSN, | ||
| environment, | ||
| integrations: [ | ||
| new BrowserTracing({ | ||
| tracingOrigins | ||
| }) | ||
| ], | ||
|
|
||
| // Set tracesSampleRate to 1.0 to capture 100% | ||
| // of transactions for performance monitoring. | ||
| // We recommend adjusting this value in production | ||
| tracesSampleRate: 1.0, | ||
| release: getAppVersionNumber() | ||
| }); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log('Sentry tracing initialized'); | ||
| } else { | ||
| // eslint-disable-next-line no-console | ||
| console.log('no Sentry configuration available'); | ||
| } | ||
| console.log('sentry is disabled in the GDS'); | ||
| }; | ||
|
|
||
| export default initSentry; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentry packages still bundled despite removal of initialization
Medium Severity
Sentry initialization is disabled but
@sentry/reactand@sentry/tracingremain as dependencies in bothgds-admin-ui/package.jsonandgds-user-ui/package.json. Multiple source files still actively import and use Sentry APIs:captureExceptionin three admin UI components,Sentry.withProfiler(App)wrapping the entire user UI app tree inApp.tsx, andSentry.ErrorBoundaryin several user UI components. These are now dead code, and the ~200KB Sentry SDK is still included in the production bundles despite serving no purpose.Additional Locations (1)
web/gds-user-ui/src/application/config/sentry.ts#L1-L5Reviewed by Cursor Bugbot for commit 6e6510e. Configure here.