This repository was archived by the owner on Apr 10, 2025. It is now read-only.
Open
Conversation
Author
|
Supersedes #1. |
Author
|
dotta
approved these changes
Jul 23, 2018
Member
dotta
left a comment
dotta
left a comment
There was a problem hiding this comment.
Metacomment: I wonder if adding a bit of logging around some operation might help if things don't work as expected (e.g., version extraction, artifacts added to the classpath, etc). But you are the one better suited to know if this is worth or not.
| scalaSwingPrefix, hydraPrefix, hydraBridgePrefix, scalaLoggingPrefix, | ||
| logbackClassicPrefix, logbackCorePrefix, slf4jPrefix, | ||
| hydraReflectPrefix, scalaXmlPrefix, license4jPrefix, | ||
| hydraDashboardPrefix, hydraLicenseCheckingPrefix), presumedLibraryVersionString).filter { |
Member
There was a problem hiding this comment.
This list is something that will eventually get out of sync (one day or another we might add or remove something). Not sure if it's possible to do it some other way, but I wanted to raise the concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.