Tpetra: fix compile error with sycl #14725
Conversation
jhux2
added
pkg: Tpetra
AT: AUTOMERGE
|
CDash for AT1 results [Only accessible from Sandia networks] |
|
Your PR updated files that did not respect package formatting settings. Patchdiff --git a/packages/tpetra/core/src/Tpetra_CrsGraph_def.hpp b/packages/tpetra/core/src/Tpetra_CrsGraph_def.hpp
index 3b6762ba..cb0fe481 100644
--- a/packages/tpetra/core/src/Tpetra_CrsGraph_def.hpp
+++ b/packages/tpetra/core/src/Tpetra_CrsGraph_def.hpp
@@ -7207,10 +7207,10 @@ void CrsGraph<LocalOrdinal, GlobalOrdinal, Node>::insertGlobalIndicesDevice(
#endif
#ifdef KOKKOS_ENABLE_SYCL
-#define CRSGRAPH_INNER_ABORT(lin) \
- do { \
+#define CRSGRAPH_INNER_ABORT(lin) \
+ do { \
sycl::ext::oneapi::experimental::printf("ERROR: Tpetra_CrsGraph_def.hpp:%d", lin); \
- Kokkos::abort("error"); \
+ Kokkos::abort("error"); \
} while (0)
#else
#define CRSGRAPH_INNER_ABORT(lin) \More details about our use of clang-format and other tools can be found in the wiki. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Using Repos:
Pull Request Author: jhux2 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand) |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Signed-off-by: Jonathan Hu <[email protected]>
jhux2
force-pushed
the
fix-sycl-error
branch
from
6de9f12 to
589e708
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Using Repos:
Pull Request Author: jhux2 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand) |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
@trilinos/tpetra
Motivation
Tpetra is failing to compile with SYCL enabled.
Related Issues
Stakeholder Feedback
It is I.
Testing
Confirmed fix locally.