Skip to content

Zoltan2 TPLTraits: Fix optimization bug #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Zoltan2 TPLTraits: Fix optimization bug #14720

wants to merge 1 commit into from
+6 −0

Conversation

@cgcgcg
Copy link
Contributor

@cgcgcg cgcgcg commented Nov 20, 2025

@trilinos/zoltan2 @achauphan @sebrowne

Motivation

Fix bug in assignment between different index types.

@cgcgcg cgcgcg self-assigned this Nov 20, 2025
@cgcgcg cgcgcg requested a review from a team as a code owner November 20, 2025 23:32
@cgcgcg cgcgcg added pkg: Zoltan2 AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Nov 20, 2025

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

@cgcgcg cgcgcg requested a review from egboman November 20, 2025 23:35
@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Using Repos:

Repo: TRILINOS (cgcgcg/Trilinos)
  • Branch: zoltan2tpltraits_fix
  • SHA: 8eadc27
  • Mode: TEST_REPO

Pull Request Author: cgcgcg

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)


CDash Test Results for PR# 14720.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

egboman
egboman approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@egboman egboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cgcgcg ! This whole approach should be revisited (later). Maybe we should insist Zoltan2 and TPL use the same integer types (32 or 64 bits) and we would not need any conversion.

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ egboman ]!

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 21, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

trilinos-autotester commented Nov 22, 2025

Cannot Merge Pull Request# 14720: Github Mergeability = blocked; Git Mergeable = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egboman egboman egboman approved these changes

Assignees

@cgcgcg cgcgcg

Labels

AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: Zoltan2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cgcgcg @trilinos-autotester @egboman