-
Notifications
You must be signed in to change notification settings - Fork 607
Teuchos: POSIX code in Trilinos not compatible with Windows #14718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Teuchos: POSIX code in Trilinos not compatible with Windows #14718
Conversation
|
CDash for AT1 results [Only accessible from Sandia networks] |
…pilers The WIN32 API includes a compatible counterpart to the POSIX functions introduced in the commit referenced in the issue description (popen and pclose). The Windows versions have the same parameters, return type, and behavior, but the function name is different (_popen and _pclose). There is also a correction to the return value from the function std::filesystem::canonical, which is being assigned to a std::string when the function returns a std::filesystem::path. Signed-off-by: Heidi Thornquist <[email protected]>
d396422 to
aa60b12
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Using Repos:
Pull Request Author: hkthorn |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand) |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
cgcgcg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hkthorn !
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True |
@trilinos/teuchos
Motivation
The WIN32 API includes a compatible counterpart to the POSIX functions introduced in the commit referenced in the issue description (popen and pclose). The Windows versions have the same parameters, return type, and behavior, but the function name is different (_popen and _pclose). There is also a correction to the return value from the function std::filesystem::canonical, which is being assigned to a std::string when the function returns a std::filesystem::path.
Related Issues
Stakeholder Feedback
Testing
Windows development and test machine with this compiler stack:
Visual Studio 2022 version 17.9.2
Intel OneAPI Base Toolkit version 2024.2
Intel HPC ToolKit with Intel(R) MPI Library for Windows* OS, Version 2021.13 Build 20240701