Skip to content

Conversation

@hkthorn
Copy link
Contributor

@hkthorn hkthorn commented Nov 20, 2025

@trilinos/teuchos

Motivation

The WIN32 API includes a compatible counterpart to the POSIX functions introduced in the commit referenced in the issue description (popen and pclose). The Windows versions have the same parameters, return type, and behavior, but the function name is different (_popen and _pclose). There is also a correction to the return value from the function std::filesystem::canonical, which is being assigned to a std::string when the function returns a std::filesystem::path.

Related Issues

Stakeholder Feedback

Testing

Windows development and test machine with this compiler stack:

Visual Studio 2022 version 17.9.2
Intel OneAPI Base Toolkit version 2024.2
Intel HPC ToolKit with Intel(R) MPI Library for Windows* OS, Version 2021.13 Build 20240701

@hkthorn hkthorn self-assigned this Nov 20, 2025
@hkthorn hkthorn requested a review from a team as a code owner November 20, 2025 18:30
@hkthorn hkthorn added the pkg: Teuchos Issues primarily dealing with the Teuchos Package label Nov 20, 2025
@github-actions
Copy link

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

…pilers

The WIN32 API includes a compatible counterpart to the POSIX functions introduced
in the commit referenced in the issue description (popen and pclose). The Windows
versions have the same parameters, return type, and behavior, but the function name
is different (_popen and _pclose).  There is also a correction to the return value
from the function std::filesystem::canonical, which is being assigned to a std::string
when the function returns a std::filesystem::path.

Signed-off-by: Heidi Thornquist <[email protected]>
@hkthorn hkthorn force-pushed the 14717_Teuchos_POSIX_code_in_Trilinos_not_compatible_with_Windows branch from d396422 to aa60b12 Compare November 20, 2025 18:33
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Using Repos:

Repo: TRILINOS (hkthorn/Trilinos)
  • Branch: 14717_Teuchos_POSIX_code_in_Trilinos_not_compatible_with_Windows
  • SHA: aa60b12
  • Mode: TEST_REPO

Pull Request Author: hkthorn

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)


CDash Test Results for PR# 14718.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@hkthorn hkthorn requested a review from cgcgcg November 20, 2025 18:51
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

Copy link
Contributor

@cgcgcg cgcgcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hkthorn !

@cgcgcg cgcgcg added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Nov 20, 2025
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester
Copy link
Contributor

Cannot Merge Pull Request# 14718: Github Mergeability = blocked; Git Mergeable = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: Teuchos Issues primarily dealing with the Teuchos Package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants