-
Notifications
You must be signed in to change notification settings - Fork 607
PyTrilinos2: Changes #14647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
PyTrilinos2: Changes #14647
Conversation
Signed-off-by: Christian Glusa <[email protected]>
Signed-off-by: Christian Glusa <[email protected]>
Signed-off-by: Christian Glusa <[email protected]>
|
CDash for AT1 results [Only accessible from Sandia networks] |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
|
@trilinos/framework It looks like none of the AT2 images are capable of building PyTrilinos2. What's the path forward for enabling testing? |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
That's annoying, I thought the Clang one would have worked (but it appears that its configure output got missed when submitting to CDash). I'm going to re-run that one to see if we get configure output and can draw a conclusion as to what is going wrong. The other ones I'm fairly sure don't directly include LLVM (though I thought you and I had discussed that in the past and that they did, honestly). I'm loathe to install that large of a package into all of the images, but if that's what we need to do then that's fairly straightfowards. Would testing only on the Clang configuration be enough (for short term and/or for long term)? |
|
I think a single configuration (say, gcc+openmpi) would be sufficient for the moment. Would we have to add a hard disable for PyTrilinos2 in all other builds for this to work? |
|
I think yes, but that's not too awful. I looked at a couple of the failures, and they're similar. Most of the containers are failing to find LLVM, which does make some sense since we never initialize it in the environment (though it IS installed via Spack). The Clang one specifically does not install those dependencies, so it fails to find binder (even though it DOES find LLVM because that's installed for the compiler). Fastest way to get this working is to try adding a |
|
Yes, I'm happy to add that as part of this PR. Thanks! |
kliegeois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
Signed-off-by: Christian Glusa <[email protected]>
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
Using Repos:
Pull Request Author: cgcgcg |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_CompSim
Jenkins Parameters
|
|
@sebrowne Looks like the gcc10-openmpi4 build worked. It had some build error, but these are things that I should fix as part of PyTrilinos2. Should I add a hard disable for PyTrilinos2 in all other builds to the PR config ini? |
Yes let's go with that for now. I believe that will work and take precedence over the auto-enable. |
@trilinos/pytrilinos2
Motivation
Fix some bugs and try to switch on testing. This should pass on AT2.