Skip to content

Conversation

@cgcgcg
Copy link
Contributor

@cgcgcg cgcgcg commented Nov 3, 2025

@trilinos/pytrilinos2

Motivation

Fix some bugs and try to switch on testing. This should pass on AT2.

Signed-off-by: Christian Glusa <[email protected]>
Signed-off-by: Christian Glusa <[email protected]>
@cgcgcg cgcgcg self-assigned this Nov 3, 2025
@cgcgcg cgcgcg requested a review from a team as a code owner November 3, 2025 21:28
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

brian-kelley
brian-kelley previously approved these changes Nov 3, 2025
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2593
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 1bb2c32
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e

Build Information

Test Name: PR_CompSim

  • Build Num: 907
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gcc-openmpi_release_static_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_compsim
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request (Non-blocking)
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 1bb2c32
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e

Using Repos:

Repo: TRILINOS (cgcgcg/Trilinos)
  • Branch: pytril2_fixes
  • SHA: 1bb2c32
  • Mode: TEST_REPO

Pull Request Author: cgcgcg

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Nov 3, 2025

@trilinos/framework It looks like none of the AT2 images are capable of building PyTrilinos2. What's the path forward for enabling testing?

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2593
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 1bb2c32
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e

Build Information

Test Name: PR_CompSim

  • Build Num: 907
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gcc-openmpi_release_static_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_compsim
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request (Non-blocking)
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 1bb2c32
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e


CDash Test Results for PR# 14647.


Wiki: How to Reproduce PR Testing Builds and Errors.

@sebrowne
Copy link
Contributor

sebrowne commented Nov 4, 2025

@trilinos/framework It looks like none of the AT2 images are capable of building PyTrilinos2. What's the path forward for enabling testing?

That's annoying, I thought the Clang one would have worked (but it appears that its configure output got missed when submitting to CDash). I'm going to re-run that one to see if we get configure output and can draw a conclusion as to what is going wrong.

The other ones I'm fairly sure don't directly include LLVM (though I thought you and I had discussed that in the past and that they did, honestly). I'm loathe to install that large of a package into all of the images, but if that's what we need to do then that's fairly straightfowards. Would testing only on the Clang configuration be enough (for short term and/or for long term)?

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Nov 4, 2025

I think a single configuration (say, gcc+openmpi) would be sufficient for the moment. Would we have to add a hard disable for PyTrilinos2 in all other builds for this to work?

@sebrowne
Copy link
Contributor

sebrowne commented Nov 4, 2025

I think yes, but that's not too awful.

I looked at a couple of the failures, and they're similar. Most of the containers are failing to find LLVM, which does make some sense since we never initialize it in the environment (though it IS installed via Spack). The Clang one specifically does not install those dependencies, so it fails to find binder (even though it DOES find LLVM because that's installed for the compiler).

Fastest way to get this working is to try adding a module load llvm in the AT2.yml file for the configuration where we want it to work (e.g. gcc+openmpi), but the long-term fix is to add that to our Dockerfiles. Are you okay with trying that as part of this PR and we can leave it in temporarily until we update the Dockerfiles?

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Nov 4, 2025

Yes, I'm happy to add that as part of this PR. Thanks!

kliegeois
kliegeois previously approved these changes Nov 4, 2025
Copy link
Contributor

@kliegeois kliegeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@cgcgcg cgcgcg dismissed stale reviews from kliegeois and brian-kelley via a1083e6 November 4, 2025 22:20
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2610
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA a1083e6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e

Build Information

Test Name: PR_CompSim

  • Build Num: 924
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gcc-openmpi_release_static_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_compsim
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request (Non-blocking)
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA a1083e6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e

Using Repos:

Repo: TRILINOS (cgcgcg/Trilinos)
  • Branch: pytril2_fixes
  • SHA: a1083e6
  • Mode: TEST_REPO

Pull Request Author: cgcgcg

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2610
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA a1083e6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e

Build Information

Test Name: PR_CompSim

  • Build Num: 924
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gcc-openmpi_release_static_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_compsim
PR_LABELS pkg: PyTrilinos2
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request (Non-blocking)
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA a1083e6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0ddb43e


CDash Test Results for PR# 14647.


Wiki: How to Reproduce PR Testing Builds and Errors.

@sebrowne sebrowne added the AT2-SpecialApprove (Beta) Special approval label for AT2. label Nov 5, 2025
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2612
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: PyTrilinos2;AT2-SpecialApprove
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA cca3e39
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 99d7ee4

Build Information

Test Name: PR_CompSim

  • Build Num: 926
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gcc-openmpi_release_static_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_compsim
PR_LABELS pkg: PyTrilinos2;AT2-SpecialApprove
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request (Non-blocking)
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA cca3e39
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 99d7ee4

Using Repos:

Repo: TRILINOS (cgcgcg/Trilinos)
  • Branch: pytril2_fixes
  • SHA: cca3e39
  • Mode: TEST_REPO

Pull Request Author: cgcgcg

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 2612
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: PyTrilinos2;AT2-SpecialApprove
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA cca3e39
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 99d7ee4

Build Information

Test Name: PR_CompSim

  • Build Num: 926
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gcc-openmpi_release_static_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_compsim
PR_LABELS pkg: PyTrilinos2;AT2-SpecialApprove
PULLREQUESTNUM 14647
PULLREQUEST_CDASH_TRACK Pull Request (Non-blocking)
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA cca3e39
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 99d7ee4


CDash Test Results for PR# 14647.


Wiki: How to Reproduce PR Testing Builds and Errors.

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Nov 5, 2025

@sebrowne Looks like the gcc10-openmpi4 build worked. It had some build error, but these are things that I should fix as part of PyTrilinos2. Should I add a hard disable for PyTrilinos2 in all other builds to the PR config ini?

@sebrowne
Copy link
Contributor

sebrowne commented Nov 5, 2025

@sebrowne Looks like the gcc10-openmpi4 build worked. It had some build error, but these are things that I should fix as part of PyTrilinos2. Should I add a hard disable for PyTrilinos2 in all other builds to the PR config ini?

Yes let's go with that for now. I believe that will work and take precedence over the auto-enable.

@cgcgcg cgcgcg added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) AT2-SpecialApprove (Beta) Special approval label for AT2. pkg: PyTrilinos2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants