Implement askpass support #1354
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way they rather than silently discarding the error message and doing another authentication attempt, they properly report the error message and cause sudo to exit. This way for example pam_faillock won't cause a persistent error like incorrect SUDO_ASKPASS value (once implemented) to be treated as multiple successive failed password attempts.
For example a timeout or ctrl+d. In addition don't allow PAM to ask for another password when an input error happened. We will still retry if the password that was entered was incorrect of course. This matches the behavior of og sudo.
This makes it slightly easier to add options in the future.
In practice I didn't observe any dangerous fds leaking to the editor process. Only the sockets used for communication with the parent process got leaked. The parent process already does not blindly trust writes to those sockets, so leaking them is fine. Still as a defence-in-depth when for example a PAM module forgets to close a file, add the missing mark_fds_as_cloexec anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still missing tests.
Fixes #1249
Based on #1346