Skip to content

Various improvements to the passwd_timeout tests #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Various improvements to the passwd_timeout tests #1190

wants to merge 1 commit into from
+10 −9

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Jul 9, 2025

  • Fix "token exceeds maximum length" by rounding the division result
  • Assert exit code / kill signal to ensure the process exited for the right reason.
  • Fail the zero_time_out test when sudo crashed with a signal before we kill it.

@bjorn3 bjorn3 requested a review from squell July 9, 2025 13:38
@bjorn3
Various improvements to the passwd_timeout tests
84d8077 
* Fix "token exceeds maximum length" by rounding the division result
* Assert exit code / kill signal to ensure the process exited for the
  right reason.
* Fail the zero_time_out test when sudo crashed with a signal before we
  kill it.
@bjorn3 bjorn3 force-pushed the test_improvement branch from 6e6598a to 84d8077 Compare July 14, 2025 09:56
@squell squell added minor minor issue, PR without an issue test-framework labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squell squell Awaiting requested review from squell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
minor minor issue, PR without an issue test-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn3 @squell