ZDICT_analyzeEntropy cleanup

[michielp1807]

Of course we'd really like analyze_entropy_internal to be safe eventually, but it uses a lot of functions from the compression side of zstd that we haven't started to clean up yet

[codecov]

Codecov Report

❌ Patch coverage is 74.84277% with 80 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/dictBuilder/zdict.rs	80.37%	53 Missing ⚠️
lib/compress/zstd_opt.rs	0.00%	13 Missing ⚠️
lib/compress/zstd_compress.rs	68.18%	7 Missing ⚠️
lib/compress/zstd_compress_superblock.rs	0.00%	6 Missing ⚠️
lib/decompress/zstd_decompress_block.rs	50.00%	1 Missing ⚠️

Flag	Coverage Δ
test-aarch64-apple-darwin	33.71% <74.21%> (+0.96%)	⬆️
test-aarch64-unknown-linux-gnu	31.61% <73.27%> (+0.92%)	⬆️
test-i686-unknown-linux-gnu	31.68% <72.95%> (+0.93%)	⬆️
test-x86_64-unknown-linux-gnu	33.81% <73.89%> (+0.90%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
lib/common/zstd_internal.rs	91.22% <ø> (ø)
lib/compress/zstd_compress_literals.rs	70.56% <100.00%> (ø)
lib/compress/zstd_compress_sequences.rs	67.29% <100.00%> (ø)
lib/decompress/zstd_decompress.rs	63.82% <100.00%> (-0.09%)	⬇️
lib/dictBuilder/cover.rs	80.82% <ø> (+1.62%)	⬆️
lib/dictBuilder/fastcover.rs	78.86% <ø> (ø)
lib/decompress/zstd_decompress_block.rs	76.39% <50.00%> (-0.09%)	⬇️
lib/compress/zstd_compress_superblock.rs	0.00% <0.00%> (ø)
lib/compress/zstd_compress.rs	39.45% <68.18%> (-0.34%)	⬇️
lib/compress/zstd_opt.rs	0.00% <0.00%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[folkertdev]

This does look good, although codecov is not too happy here. Is there any way we can improve coverage before merging these changes?

[folkertdev]

test_train_from_buffer_legacy mag wel een #[cfg(miri, ignore)] krijgen

[michielp1807]

Most of the remaining uncovered lines are either error handling or debug prints