Skip to content

Conversation

TychoVrahe
Copy link

This PR simplifies image_validation and only leaves custom, CoSi based signatures.

Dev keys are hardcoded for now.

@TychoVrahe TychoVrahe requested a review from Copilot May 16, 2025 13:19
@TychoVrahe TychoVrahe self-assigned this May 16, 2025
@TychoVrahe TychoVrahe changed the base branch from main to v2.1.0-ncs3-branch May 16, 2025 13:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the image validation signatures to use a custom CoSi-based implementation by replacing previous signature mechanisms with Trezor-crypto’s ed25519-donna sources and by hardcoding development keys for the time being.

  • Added several new Trezor-crypto source files in boot/zephyr/CMakeLists.txt.
  • Updated boot/bootutil/zephyr/CMakeLists.txt to include the new Trezor-crypto directory.
  • Added a new file in boot/bootutil/trezor-crypto containing a relative path reference.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
boot/zephyr/CMakeLists.txt Introduced new source files for Trezor-crypto and disabled precomputation for Ed25519.
boot/bootutil/zephyr/CMakeLists.txt Added an include directory pointing to the Trezor-crypto sources.
boot/bootutil/trezor-crypto Added a file with a relative path reference to the crypto directory.
Comments suppressed due to low confidence (1)

boot/bootutil/zephyr/CMakeLists.txt:12

  • Ensure that the relative path '../trezor-crypto' correctly resolves to the intended directory across all build configurations to prevent potential include path issues.
+  ../trezor-crypto

@TychoVrahe TychoVrahe force-pushed the tychovrahe/sig/cosi branch 2 times, most recently from 96cf6ac to 19134f0 Compare May 16, 2025 13:26
@TychoVrahe TychoVrahe requested a review from hiviah May 19, 2025 11:58
Copy link

@hiviah hiviah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes are mostly documentation-wise since we will rely on this to be readable.

@hiviah hiviah requested review from hiviah and removed request for hiviah June 9, 2025 15:10
@hiviah hiviah marked this pull request as draft June 12, 2025 00:38
@hiviah hiviah requested review from M1nd3r and hiviah and removed request for hiviah and M1nd3r June 12, 2025 00:39
@TychoVrahe TychoVrahe marked this pull request as ready for review June 19, 2025 08:40
@TychoVrahe TychoVrahe force-pushed the tychovrahe/sig/cosi branch from 2c37fa1 to a1c4b06 Compare June 25, 2025 06:32
@TychoVrahe TychoVrahe changed the base branch from v2.1.0-ncs3-branch to tychovrahe/sig/trezor-v2.1.0-ncs3 June 25, 2025 06:40
@TychoVrahe TychoVrahe merged commit c4fa868 into tychovrahe/sig/trezor-v2.1.0-ncs3 Jun 25, 2025
1 of 59 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/sig/cosi branch June 25, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants