-
-
Notifications
You must be signed in to change notification settings - Fork 1
change signatures to cosi #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change signatures to cosi #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the image validation signatures to use a custom CoSi-based implementation by replacing previous signature mechanisms with Trezor-crypto’s ed25519-donna sources and by hardcoding development keys for the time being.
- Added several new Trezor-crypto source files in boot/zephyr/CMakeLists.txt.
- Updated boot/bootutil/zephyr/CMakeLists.txt to include the new Trezor-crypto directory.
- Added a new file in boot/bootutil/trezor-crypto containing a relative path reference.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
boot/zephyr/CMakeLists.txt | Introduced new source files for Trezor-crypto and disabled precomputation for Ed25519. |
boot/bootutil/zephyr/CMakeLists.txt | Added an include directory pointing to the Trezor-crypto sources. |
boot/bootutil/trezor-crypto | Added a file with a relative path reference to the crypto directory. |
Comments suppressed due to low confidence (1)
boot/bootutil/zephyr/CMakeLists.txt:12
- Ensure that the relative path '../trezor-crypto' correctly resolves to the intended directory across all build configurations to prevent potential include path issues.
+ ../trezor-crypto
96cf6ac
to
19134f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes are mostly documentation-wise since we will rely on this to be readable.
2c37fa1
to
a1c4b06
Compare
c4fa868
into
tychovrahe/sig/trezor-v2.1.0-ncs3
This PR simplifies image_validation and only leaves custom, CoSi based signatures.
Dev keys are hardcoded for now.