Skip to content

Conversation

ObserverOfTime
Copy link
Member

Closes #2

@ObserverOfTime ObserverOfTime requested a review from amaanq July 9, 2025 09:06
@clason
Copy link

clason commented Jul 10, 2025

Why did you delete the release workflow?

@ObserverOfTime
Copy link
Member Author

I find release-please confusing and unnecessary.
Bump the version via the CLI, tag it, and the reusable release workflow will handle the rest.
If we want a changelog we can use git-cliff.

@clason
Copy link

clason commented Jul 10, 2025

Ok, but I'd still like to separate the release and publish steps.

@ObserverOfTime
Copy link
Member Author

They both happen when a tag is pushed.

@clason
Copy link

clason commented Jul 10, 2025

Yes, but they can fail separately and for different reasons.

@ObserverOfTime
Copy link
Member Author

If any of the jobs fails it won't impact the rest. Should it? If so, how?

@clason
Copy link

clason commented Jul 10, 2025

I just want separate workflows so we can disable them separately, same as other grammars.

@clason clason merged commit 27816eb into master Jul 10, 2025
4 checks passed
@clason clason deleted the update branch July 10, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Update to tree-sitter >= 0.23
2 participants