Conversation
Collaborator
kdcurry
commented
Feb 26, 2026
- Widen LOG_LIKELIHOOD_DIFF_TOLERANCE to 1e-5 (from 1e-9)
- Fix bug to keep_counts when min-abundance threshold is applied
- In the case where min-abundance threshold is applied, “unclassified mapped” reads were counted after the min-abundance threshold was applied, even for the output without the min-abundance threshold applied. This has been corrected, resulting in two separate unclassified mapped counts (and two output sequence files if --output-unclassified if enforced)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.