added statement_timeout to connection_config

[alamirfan]

Problem

Getting this error in tap-postgres. psycopg2.errors.QueryCanceled: canceling statement due to statement timeout

Proposed changes

Added statement_timeout in connection config so that if it is provided then the connection will be held for long time.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• Description above provides context of the change
• I have added tests that prove my fix is effective or that my feature works
• Unit tests for changes (not needed for documentation changes)
• CI checks pass with my changes
• Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
• Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
• Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
• Commits follow "How to write a good git commit message"
• Relevant documentation is updated including usage instructions

[koszti]

this is cool, but can we try making it more generic and prepare it somehow to accept any valid postgres options?

What if we introduce a new options key in config.json:

{
  "host": "x", 
  "port": "x",
  "user": "x",
  "password": "x",
  "dbname": "x",
  "options": [
    "statement_timeout=60s",
    "another_option=120",
    "and_another_option=180"
  ]
} 

And in the code it would be something like this:

cfg['options'] = ' '.join(map('-c {0}'.format, conn_config.get('options',[])))

what do you think?

[alamirfan]

PR Updated

[koszti]

thanks, how we want to deal with the case if the options key in the config.json is not a list but a string or a number? Can we raise an exception with a meaningful error message in that case?

Adding some sort of unit test for open_connection would be great as well. Maybe we need to mock the psycopg2.connect ?