This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Open
Conversation
208c9d0 to
82085b4
Compare
|
The upper bound limit also forcing Meltano to install 1.8.4 version in python 3.10+ environments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the project specifies an upper-bound limit for the Python version as
<3.10. This could potentially limit the usage of the project for environments with newer Python versions, even if the project is compatible with them.Proposed changes
This PR removes the upper-bound limit for the Python version. By doing so, the project can be used in environments with Python versions greater than 3.9 without the need for overriding or bypassing the specified requirements.
I executed both the unit tests and the integration tests with Python 3.11 and they are both passing ✅
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN](if applicable. AP-NNNN = JIRA ID)AP-NNN(if applicable. AP-NNN = JIRA ID)