This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Open
Conversation
Saves a lot of network round trips.
Saves a lot of network roundtrips. Could also be done for the other array types, but I didn't have a need for them and not enough time for testing.
Author
|
I think that the CSV approach to parsing can be optimized even further. Can anybody share benchmarks (e.g. entries per second or minute and hardware) for log-based processing for tables without arrays or hstores? I know that it also depends on the schema of the tables but it would be great to get a ballpark figure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation for log-based replication uses the Postgres server for type casts of hstore and array values. This will cause network requests to the Postgres server for each hstore or array column for every affected line in the log. Even worse, it uses a new connection for each request. With TCP and TLS handshakes and PG authentication, this means multiple network roundtrips per typecast. Total madness.
Proposed changes
Parse hstore and select array values locally. Could also be done for the other array types but I didn't have time to test it. The solution for array parsing is based on singer-io/tap-postgres#72
The results speak for themselves: In my case, I wasn't able to use my pipeline as the processing of 3 hours of WAL data would have taken about 4 months. Speed improvement after the change: > 1000x.
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
xin the boxes that applyChecklist
setup.pyis an individual PR and not mixed with feature or bugfix PRs[AP-NNNN](if applicable. AP-NNNN = JIRA ID)AP-NNN(if applicable. AP-NNN = JIRA ID)