fix(sqlite): migrate datetime format builders off time 0.3.48-depreca…#4317
Open
LiamCarPer wants to merge 2 commits into
Open
fix(sqlite): migrate datetime format builders off time 0.3.48-depreca…#4317LiamCarPer wants to merge 2 commits into
LiamCarPer wants to merge 2 commits into
Conversation
LiamCarPer
force-pushed
the
fix/sqlite-time-format-migration
branch
from
2e99cb4 to
8f9a00a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Closes #4310.
Replaces the #![allow(deprecated)] stopgap from #4310 with the actual migration to format_description! macros, matching the approach used by the mysql and postgres drivers.
Is this a breaking change?
No. The parsing behavior is unchanged — the same format descriptors are produced, just constructed via the format_description! macro instead of manually-built BorrowedFormatItem trees.