Add SQLite integration test for #[sqlx(json)] on TEXT columns#4316
Closed
xiangkaiz wants to merge 1 commit into
Closed
Add SQLite integration test for #[sqlx(json)] on TEXT columns#4316xiangkaiz wants to merge 1 commit into
xiangkaiz wants to merge 1 commit into
Conversation
Covers reading a JSON-as-TEXT column into a FromRow struct field annotated with #[sqlx(json)], and the error path where invalid JSON surfaces as sqlx::Error::ColumnDecode. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite stores JSON as
TEXT. This adds integration test coverage for reading such a column into aFromRowstruct field annotated with#[sqlx(json)], decoding it viaserde_json.The
#[sqlx(json)]attribute and its SQLiteJson<T>decode path already exist; this PR adds the missing test coverage:it_reads_json_from_text_column— selects'{"key": "value"}'from aTEXTcolumn into a struct with#[sqlx(json)] data: serde_json::Value.it_surfaces_invalid_json_as_column_decode_error— invalid JSON surfaces assqlx::Error::ColumnDecode.Test plan
cargo test -p sqlx --test sqlite-derives(withsqlite,macros,migrate,jsonfeatures) — all 8 tests pass, including the 2 new ones.🤖 Generated with Claude Code