fix(macros): added SQLX_SQLITE_REGISTER_REGEXP environment variable#4313
Open
XVanilor wants to merge 1 commit into
Open
fix(macros): added SQLX_SQLITE_REGISTER_REGEXP environment variable#4313XVanilor wants to merge 1 commit into
XVanilor wants to merge 1 commit into
Conversation
- fix issue transact-rs#3070 - allows sqlx-cli prepare to work with sqlite regexp
XVanilor
force-pushed
the
fix/vanilor/add-sqlite-regexp-macros-support
branch
from
ec6c531 to
9ddf6a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Fixes #3070
As it's my first ever contribution to an open-source project, please tell me everything I've got wrong or if I can improve the PR to be clearer.
This intend to allow sqlite
regexpfunction to be used with macros, it extends an already-supported feature.The change also allows by-design the use of the new
SQLX_SQLITE_REGISTER_REGEXPwithsqlx-cli preparecommand.I'm waiting a run of CI to make sure that the new test does not fail (ie if the new
SQLX_SQLITE_REGISTER_REGEXPneeds to be added to the existing environment workflow).Is this a breaking change?
No.