[pull] master from golang:master - #177
Merged
Merged
Conversation
Go asm syntax:
IBAR $hint
Equivalent platform assembler syntax:
ibar $hint
Change-Id: I4269b644ad66c48ab8e0998797f5c1fc517d5c8a
Reviewed-on: https://go-review.googlesource.com/c/go/+/811400
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mark Freeman <markfreeman@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: sophie zhao <zhaoxiaolin@loongson.cn>
Reviewed-by: Meidan Li <limeidan@loongson.cn>
The procyield() function should yield the processor as in other architectures.
However, since loong64 lacks a native yield instruction, NOP instructions are
used to emulate this behavior. On loong64, NOP instructions are only decoded
but not executed.
Benchmarks/sweet/CockroachDB:
GOARCH: loong64
CPU: Loongson-3C6000/S @ 2200.00MHz
GOOS: linux
| old.3c6000.results | new.3c6000.results |
| sec/op | sec/op vs base |
CockroachDBkv0/nodes=1-16 576.5µ ± 2% 490.3µ ± 2% -14.95% (p=0.002 n=6)
CockroachDBkv50/nodes=1-16 620.7µ ± 1% 527.4µ ± 1% -15.03% (p=0.002 n=6)
CockroachDBkv95/nodes=1-16 654.6µ ± 1% 570.7µ ± 1% -12.82% (p=0.002 n=6)
CockroachDBkv0/nodes=3-16 568.6µ ± 2% 491.1µ ± 1% -13.64% (p=0.002 n=6)
CockroachDBkv50/nodes=3-16 622.4µ ± 1% 528.7µ ± 1% -15.05% (p=0.002 n=6)
CockroachDBkv95/nodes=3-16 658.5µ ± 1% 564.2µ ± 1% -14.33% (p=0.002 n=6)
geomean 615.9µ 527.8µ -14.31%
| old.36c000.results | new.3c6000.results |
| write-avg-latency-sec | write-avg-latency-sec vs base |
CockroachDBkv0/nodes=1-16 57.65m ± 2% 49.00m ± 2% -15.00% (p=0.002 n=6)
CockroachDBkv50/nodes=1-16 74.85m ± 2% 60.85m ± 1% -18.70% (p=0.002 n=6)
CockroachDBkv95/nodes=1-16 83.55m ± 3% 71.80m ± 3% -14.06% (p=0.002 n=6)
CockroachDBkv0/nodes=3-16 56.90m ± 2% 49.15m ± 1% -13.62% (p=0.002 n=6)
CockroachDBkv50/nodes=3-16 74.50m ± 2% 61.00m ± 2% -18.12% (p=0.002 n=6)
CockroachDBkv95/nodes=3-16 81.20m ± 5% 70.45m ± 2% -13.24% (p=0.002 n=6)
geomean 70.63m 59.69m -15.49%
| old.3c6000.results | new.3c6000.results |
| read-avg-latency-sec | read-avg-latency-sec vs base |
CockroachDBkv50/nodes=1-16 49.05m ± 2% 44.70m ± 2% -8.87% (p=0.002 n=6)
CockroachDBkv95/nodes=1-16 64.50m ± 1% 56.30m ± 1% -12.71% (p=0.002 n=6)
CockroachDBkv50/nodes=3-16 49.70m ± 3% 44.45m ± 3% -10.56% (p=0.002 n=6)
CockroachDBkv95/nodes=3-16 65.10m ± 2% 55.70m ± 1% -14.44% (p=0.002 n=6)
geomean 56.56m 49.96m -11.67%
Change-Id: I1be58faf67bd949731d63da8327ac99cc54cfa1e
Reviewed-on: https://go-review.googlesource.com/c/go/+/811401
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Meidan Li <limeidan@loongson.cn>
Reviewed-by: Keith Randall <khr@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )