[pull] master from golang:master - #174
Merged
Merged
Conversation
Now that Go 1.26 is the minimum bootstrap toolchain (CL 804523) we can drop the version dependent use of posix_fallocate on NetBSD. For #77341 Change-Id: I814c0bbda99d5f733178f6e68c380e2996b24c6d Reviewed-on: https://go-review.googlesource.com/c/go/+/811300 Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fixes #80696 Change-Id: I7a0301bd253dca97a9d6585d3a28e9d5a7e6b912 GitHub-Last-Rev: a9f28f4 GitHub-Pull-Request: #80725 Reviewed-on: https://go-review.googlesource.com/c/go/+/810660 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Mark Freeman <markfreeman@google.com> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Remove the duplicated word "the" in doc/godebug.md and in the goroutine leak profile testdata README. Change-Id: I37d56525eac35af042672982a8969afd6cc3a093 Reviewed-on: https://go-review.googlesource.com/c/go/+/810180 Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Mark Freeman <markfreeman@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Carlos Amedee <carlos@golang.org>
computeChecksum summed all 512 header bytes with a per-byte range
test substituting spaces for the checksum field at bytes 148 to 155.
The field's position is constant, so sum the bytes before and after
it in two branch-free loops and add the field's contribution
directly: 8*' ' for both sums, since int64(' ') and int64(int8(' '))
are both 32.
The checksum is computed when reading and when writing every header.
goos: darwin
goarch: arm64
pkg: archive/tar
cpu: Apple M2 Pro
│ old.hdr.txt │ new.hdr.txt │
│ sec/op │ sec/op vs base │
/Writer/USTAR-10 1.623µ ± 5% 1.357µ ± 3% -16.39% (p=0.000 n=25)
/Writer/GNU-10 1.939µ ± 4% 1.702µ ± 2% -12.22% (p=0.000 n=25)
/Writer/PAX-10 3.625µ ± 3% 3.079µ ± 2% -15.06% (p=0.000 n=25)
/Reader/USTAR-10 2.024µ ± 4% 1.873µ ± 4% -7.46% (p=0.000 n=25)
/Reader/GNU-10 917.7n ± 2% 829.3n ± 3% -9.63% (p=0.000 n=25)
/Reader/PAX-10 4.346µ ± 2% 4.185µ ± 6% -3.70% (p=0.017 n=25)
geomean 2.125µ 1.894µ -10.85%
B/op and allocs/op are unchanged.
Fixes #80635
Change-Id: I41daef9617bb8db5ec680b5fb123cd230c9d8670
GitHub-Last-Rev: 8b725ea
GitHub-Pull-Request: #80636
Reviewed-on: https://go-review.googlesource.com/c/go/+/807820
Reviewed-by: qiu laidongfeng <2645477756@qq.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Sean Liao <sean@liao.dev>
Auto-Submit: Sean Liao <sean@liao.dev>
Reviewed-by: Mark Freeman <markfreeman@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
There are already rewrite rules in generic.rules, so we can remove duplicate rules in amd64. Change-Id: Ib689e738093eeabf3530e6acb49e2bb3eb8fe81c Reviewed-on: https://go-review.googlesource.com/c/go/+/807960 Reviewed-by: Mark Freeman <markfreeman@google.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
readHeader used bytes.IndexFunc with a rune predicate to reject USTAR
and PAX headers containing non-ASCII bytes, making an uninlinable
indirect call for every byte of the 512-byte block. Scanning the
bytes directly rejects exactly the same blocks: ASCII bytes decode
one at a time, so the old scan always reached the first byte >= 0x80,
where DecodeRune returns a rune >= 0x80 (possibly RuneError).
goos: darwin
goarch: arm64
pkg: archive/tar
cpu: Apple M2 Pro
│ old │ new │
│ sec/op │ sec/op vs base │
/Reader/USTAR-10 1.955µ ± 1% 1.098µ ± 1% -43.84% (p=0.000 n=25)
/Reader/GNU-10 909.5n ± 1% 904.9n ± 1% ~ (p=0.211 n=25)
/Reader/PAX-10 4.331µ ± 1% 2.569µ ± 1% -40.68% (p=0.000 n=25)
geomean 1.975µ 1.367µ -30.79%
Fixes #80633
Change-Id: I47dd7490e06d2096fad1fa90b0fc9cabaaeb3cc3
GitHub-Last-Rev: 05dd37d
GitHub-Pull-Request: #80634
Reviewed-on: https://go-review.googlesource.com/c/go/+/807800
Auto-Submit: Sean Liao <sean@liao.dev>
Reviewed-by: Mark Freeman <markfreeman@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Sean Liao <sean@liao.dev>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Validate non-pattern module arguments before loading the module graph. Report malformed paths on stderr and exit with a non-zero status. Use module.CheckImportPath instead of module.CheckPath so paths permitted through replace directives, such as mymodule/nested, remain accepted. Add regression tests for a module path with a trailing slash and for a replacement-only module path. Fixes #36658 Change-Id: I17ba59ae0655fab78e3a715514e75479d4f45ba8 Reviewed-on: https://go-review.googlesource.com/c/go/+/802480 Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Mark Freeman <markfreeman@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The chansend signature now uses a boolean block parameter, but the comment still describes the previous pointer-based API and g.param wake-up mechanism. Update the comment to describe the current blocking and return behavior and the panic on a send to a closed channel. Tests were not run because this is a comment-only change. Change-Id: I57b1039226757a722dc7039c55a5f501b9bae8d8 GitHub-Last-Rev: 4b1108f GitHub-Pull-Request: #80780 Reviewed-on: https://go-review.googlesource.com/c/go/+/811900 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
MOVQ $0, mem encodes two bytes longer than MOVQ X15, mem, and MOVL $0, mem encodes one byte longer than MOVL X15, mem. In ABIInternal functions on amd64, X15 is maintained as zero except on Plan 9. Use the XMM forms of MOVQ and MOVL when emitting plain and indexed zero stores. Selecting the encoding during emission leaves the existing SSA operations available to store-combining rules. Retain immediate stores for ABI0 and Plan 9, where X15 is not known to contain zero. This replaces 5,598 stores when compiling the standard library, reducing text by 11,004 bytes with no change in instruction count. Change-Id: Ibccdce5fd17f81be8c2cf505c8144fa612e71101 Reviewed-on: https://go-review.googlesource.com/c/go/+/810120 Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com>
The original #80517 issue was reported on the context of gotip this CL adds two tests, one failing on 1.25 and one on 1.26 in order to justify backporting the fix. Change-Id: I7267bd36a6a3722cebed603740248665738fa52a Reviewed-on: https://go-review.googlesource.com/c/go/+/807182 Reviewed-by: Mark Freeman <markfreeman@google.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com> Reviewed-by: Keith Randall <khr@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )