fix(ci): bump bootstrap Go to 1.26.5 - #167
Merged
Merged
Conversation
Upstream commit c88c8c0 raised the minimum bootstrap toolchain to Go 1.26.0. CI still pinned 1.25.5, so make.bash failed right away with "found packages main (build.go) and building_Go_requires_Go_1_26_0_or_later (notgo126.go) in src/cmd/dist". All five workflows that build the toolchain have been red since the upstream merge in #165. Repo knowledge and CodeQL stayed green because they never run make.bash. Also bumps the go1.25.5 fallback download in quickcheck.sh and smoke_use_libafl.sh, which carried the same stale pin.
There was a problem hiding this comment.
Pull request overview
Updates the repository’s bootstrap Go toolchain pin to match the upstream requirement (Go ≥ 1.26), fixing CI breakage where ./make.bash fails immediately when bootstrapped with Go 1.25.x.
Changes:
- Bump GitHub Actions bootstrap Go version from 1.25.5 to 1.26.5 across all toolchain-building workflows.
- Bump the fallback auto-download bootstrap version used by
quickcheck.shand the LibAFL smoke runner to 1.26.5.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
misc/gosentry/tests/smoke_use_libafl.sh |
Updates the fallback bootstrap toolchain download version to Go 1.26.5. |
misc/gosentry/scripts/quickcheck.sh |
Updates the fallback bootstrap toolchain download version to Go 1.26.5. |
.github/workflows/smoke_use_libafl.yml |
Pins actions/setup-go bootstrap version to Go 1.26.5 for LibAFL smoke jobs. |
.github/workflows/go.yml |
Pins actions/setup-go bootstrap version to Go 1.26.5 for integration tests. |
.github/workflows/catch_races.yml |
Pins actions/setup-go bootstrap version to Go 1.26.5 for race-catching workflow. |
.github/workflows/catch_leaks.yml |
Pins actions/setup-go bootstrap version to Go 1.26.5 for leak-catching workflow. |
.github/workflows/catch_hangs.yml |
Pins actions/setup-go bootstrap version to Go 1.26.5 for hang-catching workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
8
to
12
| if command -v go >/dev/null 2>&1; then | ||
| bootstrap_goroot="$(go env GOROOT)" | ||
| else | ||
| bootstrap_ver="go1.25.5" | ||
| bootstrap_ver="go1.26.5" | ||
| os="$(uname -s | tr '[:upper:]' '[:lower:]')" |
Comment on lines
8
to
12
| if command -v go >/dev/null 2>&1; then | ||
| bootstrap_goroot="$(go env GOROOT)" | ||
| else | ||
| bootstrap_ver="go1.25.5" | ||
| bootstrap_ver="go1.26.5" | ||
| os="$(uname -s | tr '[:upper:]' '[:lower:]')" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream commit c88c8c0 raised the minimum bootstrap toolchain to Go 1.26.0. CI still pinned 1.25.5, so make.bash failed right away with "found packages main (build.go) and
building_Go_requires_Go_1_26_0_or_later (notgo126.go) in src/cmd/dist".
All five workflows that build the toolchain have been red since the upstream merge in #165. Repo knowledge and CodeQL stayed green because they never run make.bash.
Also bumps the go1.25.5 fallback download in quickcheck.sh and smoke_use_libafl.sh, which carried the same stale pin.
Summary
Checklist
bash misc/gosentry/scripts/quickcheck.shbash misc/gosentry/tests/smoke_use_libafl.sh(or a narrower smoke script)go testflags changed: updatedmisc/gosentry/USE_LIBAFL.mdREADME.mddocs/gosentry/*(start atdocs/gosentry/index.md)