-
Notifications
You must be signed in to change notification settings - Fork 27
Write fully filled orders to order and order size tables #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Write fully filled orders to order and order size tables #151
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused about the frontend not breaking so I checked, and in fact it broke. My best guess as to why we didn't see it on your computer is maybe you didn't rerun the server after making the changes, and you just had the server running from before. This is within your reach to fix 🙂, although there are a couple possible solutions. Also you might want to make sure the python client isn't broken.
…orders that are instafilled and then created with size 0 remain on the order book)
|
Thoughts on the one I chose? Seemed the most straightforward and non-objectionable. Interested in the pros and cons of others if it's worth your time, fine if not.
What steps would you recommend for this? (Right now I think I'm blocked on figuring out the right kernel/env setup for running python client stuff, so maybe once I fix that I'll be able to make headway without a hint here) |
|
Yep, I think that's the right change. Maybe we want to still add it if Yeah I haven't really documented some of the new python stuff. You should install uv, install dependencies with To recompile the python websocket_api file from the protobuf schema you'll want to run Otherwise the change should be logically the same as the frontend change |

No description provided.