Skip to content

Conversation

@RickiHeicklen
Copy link
Collaborator

No description provided.

@RickiHeicklen RickiHeicklen requested a review from a team as a code owner January 30, 2025 00:10
@vercel
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 4:32am

Copy link
Collaborator

@Crazytieguy Crazytieguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused about the frontend not breaking so I checked, and in fact it broke. My best guess as to why we didn't see it on your computer is maybe you didn't rerun the server after making the changes, and you just had the server running from before. This is within your reach to fix 🙂, although there are a couple possible solutions. Also you might want to make sure the python client isn't broken.

image

…orders that are instafilled and then created with size 0 remain on the order book)
@RickiHeicklen
Copy link
Collaborator Author

Thoughts on the one I chose? Seemed the most straightforward and non-objectionable. Interested in the pros and cons of others if it's worth your time, fine if not.

Also you might want to make sure the python client isn't broken.

What steps would you recommend for this? (Right now I think I'm blocked on figuring out the right kernel/env setup for running python client stuff, so maybe once I fix that I'll be able to make headway without a hint here)

@Crazytieguy
Copy link
Collaborator

Yep, I think that's the right change. Maybe we want to still add it if marketData.hasFullOrderHistory, (in which case we have all of the sizes for each order and filter for size > 0 in the svelte component), just because it's more consistent and maybe in the future we'll want to use the 0 size orders somehow.

Yeah I haven't really documented some of the new python stuff. You should install uv, install dependencies with uv sync (from the python-client directory), and then you should be able to run python files with uv run <file>. To get proper editor support you'll have to run the Python: select interpreter command and select the interpreter at python-client/.venv/bin/python (not sure if you'll need to enter this manually). Feel free to add this in the readme, I think I didn't bother because these steps happen automatically in codespaces.

To recompile the python websocket_api file from the protobuf schema you'll want to run ./compile-protos.sh

Otherwise the change should be logically the same as the frontend change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants