Add an icon on the trip report to view the replay #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
When you navigate back, it reset the period back to "today" regardless of what you previously selected. That is a preexisting issue where that field is not populated from the query parameters |
tananaev
reviewed
Dec 13, 2025
src/reports/TripReportPage.jsx
Outdated
| </IconButton> | ||
| )} | ||
| </TableCell> | ||
| <TableCell className={classes.columnAction} padding="none"> |
Member
There was a problem hiding this comment.
I think it should be part of the same column.
Earlopain
force-pushed
the
trips-replay-shortcut
branch
from
8b5b6b7 to
dac9dc7
Compare
tananaev
reviewed
Dec 13, 2025
src/reports/TripReportPage.jsx
Outdated
| ) : ( | ||
| <IconButton size="small" onClick={() => setSelectedItem(item)}> | ||
| <LocationSearchingIcon fontSize="small" /> | ||
| <Box display={'flex'}> |
Contributor
Author
There was a problem hiding this comment.
Without the icons are not displayed in a single row
Member
There was a problem hiding this comment.
ok, let's make a div with a style then
Earlopain
force-pushed
the
trips-replay-shortcut
branch
from
dac9dc7 to
9d2be4c
Compare
tananaev
reviewed
Dec 13, 2025
src/reports/TripReportPage.jsx
Outdated
| ) : ( | ||
| <IconButton size="small" onClick={() => setSelectedItem(item)}> | ||
| <LocationSearchingIcon fontSize="small" /> | ||
| <div style={{display: 'flex'}}> |
Member
There was a problem hiding this comment.
please make a class for this, like we do everywhere else
Earlopain
force-pushed
the
trips-replay-shortcut
branch
from
9d2be4c to
667af60
Compare
tananaev
reviewed
Dec 13, 2025
| display: 'none', | ||
| }, | ||
| }, | ||
| columnFlex: { |
Member
There was a problem hiding this comment.
I think we need more semantic name. maybe something like columnActionContainer
Redo of traccar#1349 Params are now already automatically added to query params and read back. So this just needs to add the link to it.
Earlopain
force-pushed
the
trips-replay-shortcut
branch
from
667af60 to
85bf858
Compare
Member
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #1349
Params are now already automatically added to query params and read back. So this just needs to add the link to it.
Screencast_20251212_232357.mp4