Repository navigation
Fix for OS Maps bug #1353 - #1354
Closed
MrNoScript wants to merge 1 commit into
Closed
MrNoScript wants to merge 1 commit into
MrNoScript wants to merge 1 commit into
Conversation
MrNoScript
force-pushed
the
fix-os-maps-bug
branch
from
April 4, 2025 13:47
e0d31d0 to
ea6f69a
Compare
tananaev
reviewed
Apr 4, 2025
| id: 'ordnanceSurvey', | ||
| title: t('mapOrdnanceSurvey'), | ||
| style: 'https://api.os.uk/maps/vector/v1/vts/resources/styles?key=EAZ8p83u72FTGiLjLC2MsTAl1ko6XQHC', | ||
| style: `https://api.os.uk/maps/vector/v1/vts/resources/styles?key=${ordnanceSurveyKey}`, |
Member
There was a problem hiding this comment.
What is the reason for using own key?
Contributor
Author
There was a problem hiding this comment.
That key appears to have been revoked by the person who originally put it in, and so the "tiles" don't load with the error "A Premium Plan is required to access Premium Data"
Member
There was a problem hiding this comment.
I never revoked it. I though maps are free and don't require any "access Premium Data".
Contributor
Author
There was a problem hiding this comment.
At zoom level 12 and above, the tiles are considered "premium", 11 and below are free - apologies.
Would the option to use our own token be more sensible? Similar to the LocationIQ service?
E.g.
const ordnanceSurveyKey = useAttributePreference('ordnanceSurveyKey') || 'YOUR TOKEN HERE';
tananaev
added a commit
that referenced
this pull request
Jun 23, 2026
Replace the hardcoded Ordnance Survey API key with a user-configurable ordnanceSurveyKey preference, gate availability on the key being set, and force the "Source Sans Pro Regular" font for api.os.uk glyphs so OS maps render correctly. Supersedes #1354 (original branch is on a now-private fork that can no longer be updated). Closes #1353. Co-Authored-By: MrNoScript <17362326+MrNoScript@users.noreply.github.com>
tananaev
added a commit
that referenced
this pull request
Jun 23, 2026
* Fix Ordnance Survey map and make API key configurable Replace the hardcoded Ordnance Survey API key with a user-configurable ordnanceSurveyKey preference, gate availability on the key being set, and force the "Source Sans Pro Regular" font for api.os.uk glyphs so OS maps render correctly. Supersedes #1354 (original branch is on a now-private fork that can no longer be updated). Closes #1353. Co-Authored-By: MrNoScript <17362326+MrNoScript@users.noreply.github.com> * Fall back to shared Ordnance Survey key and tidy ordering Keep the shared Ordnance Survey key as a fallback when the user has not set their own ordnanceSurveyKey, matching the locationIqKey pattern (always available, no attribute redirect). Move the mapOrdnanceSurveyKey label next to mapOrdnanceSurvey. --------- Co-authored-by: MrNoScript <17362326+MrNoScript@users.noreply.github.com>
Member
|
Fixed and merged under #1862. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix problem with font stack "Open Source Sans" not being found on the OS API endpoints - force the use of "Source Sans Pro Regular"