Skip to content

Add code to have authopenid handle /login #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puiterwijk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add code to have authopenid handle /login #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4293111
Add code to have authopenid handle /login
puiterwijk Jun 29, 2013
1f2c248
Wow, copy/paste errors...
puiterwijk Jul 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions authopenid/authopenid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ def trac_auth_cookie_lifetime(self):
on each authenticated access.
""")

take_default_login = Option('openid', 'take_default_login', False,
"""Set to true if /login should be handled by openid.""")

default_openid = Option('openid', 'default_openid', None,
"""Default OpenID provider for directed identity.""")

Expand Down Expand Up @@ -317,10 +320,12 @@ def get_navigation_items(self, req):
# IRequestHandler methods

def match_request(self, req):
return re.match('/(openidlogin|openidverify|openidprocess|openidlogout)\??.*', req.path_info)
return (re.match('/(openidlogin|openidverify|openidprocess|openidlogout)\??.*', req.path_info) or
(self.take_default_login and (req.path_info == '/login' or req.path_info == '/login/')))
# Please note that I am not using re.match on purpose, because /login/xmlrpc cannot be handled with openid

def process_request(self, req):
if req.path_info.startswith('/openidlogin'):
if req.path_info.startswith('/openidlogin') or (self.take_default_login and req.path_info.startswith('/login')):
return self._do_login(req)
elif req.path_info.startswith('/openidverify'):
return self._do_verify(req)
Expand Down