Skip to content

Conversation

@zeevro
Copy link

@zeevro zeevro commented Aug 7, 2025

This solves a regression in uv that makes the action fail on uv>0.8.1 (currently the latest version is 0.8.6).
Also this fixes #6.

@hugovk
Copy link
Collaborator

hugovk commented Aug 8, 2025

Thanks for the PR!

This is fixing a bug and adding a feature. Please could you split the feature into another PR?


Why is --no-sync being removed? It was added in #4.


The regression should be fixed in uv and will be in the next release:

Hopefully that'll be fairly soon given their release cadence?


This PR essentially changes:

uv run --with pre-commit-uv pre-commit ...

To:

uvx --python '${{ env.pythonLocation }}' --with pre-commit-uv pre-commit ...

Which is an alias for:

uv tool run --python '${{ env.pythonLocation }}' --with pre-commit-uv pre-commit ...

What are the key differences between uv run and uv tool run --python?

Is it still worthwhile even after astral-sh/uv#14184 is released?

@hugovk
Copy link
Collaborator

hugovk commented Aug 8, 2025

Hopefully that'll be fairly soon given their release cadence?

Now fixed in https://github.com/astral-sh/uv/releases/tag/0.8.7.

@gaborbernat
Copy link
Member

Yeah we no longer need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support more uv invocations

3 participants