Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pretty-candles-wink.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-simplikit': patch
---

use named functions in useEffect callbacks for better stack traces
13 changes: 8 additions & 5 deletions packages/core/src/hooks/useDebounce/useDebounce.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,14 @@ export function useDebounce<F extends (...args: any[]) => unknown>(
return debounce<F>(preservedCallback, wait, { edges });
}, [preservedCallback, wait, edges]);

useEffect(() => {
return () => {
debounced.cancel();
};
}, [debounced]);
useEffect(
function cancelDebouncedOnUnmount() {
return () => {
debounced.cancel();
};
},
[debounced]
);

return debounced;
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function useDebouncedCallback({
const handleChange = usePreservedCallback(onChange);
const ref = useRef({ value: false, clearPreviousDebounce: () => {} });

useEffect(() => {
useEffect(function clearDebouncedOnUnmount() {
const current = ref.current;
return () => {
current.clearPreviousDebounce();
Expand Down
30 changes: 18 additions & 12 deletions packages/core/src/hooks/useInterval/useInterval.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,24 @@ export function useInterval(callback: () => void, options: IntervalOptions) {

const preservedCallback = usePreservedCallback(callback);

useEffect(() => {
if (immediate === true && enabled) {
preservedCallback();
}
}, [immediate, preservedCallback, enabled]);
useEffect(
function runImmediateCallback() {
if (immediate === true && enabled) {
preservedCallback();
}
},
[immediate, preservedCallback, enabled]
);

useEffect(() => {
if (!enabled) {
return;
}
useEffect(
function startInterval() {
if (!enabled) {
return;
}

const id = window.setInterval(preservedCallback, delay);
return () => window.clearInterval(id);
}, [delay, preservedCallback, enabled]);
const id = window.setInterval(preservedCallback, delay);
return () => window.clearInterval(id);
},
[delay, preservedCallback, enabled]
);
}
15 changes: 9 additions & 6 deletions packages/core/src/hooks/useLoading/useLoading.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,15 @@ export function useLoading(): [boolean, <T>(promise: Promise<T>) => Promise<T>]
function useIsMountedRef() {
const ref = useRef({ isMounted: true }).current;

useEffect(() => {
ref.isMounted = true;
return () => {
ref.isMounted = false;
};
}, [ref]);
useEffect(
function trackMountedState() {
ref.isMounted = true;
return () => {
ref.isMounted = false;
};
},
[ref]
);

return ref;
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ export function usePreservedCallback<Arguments extends any[] = any[], ReturnValu
) {
const callbackRef = useRef(callback);

useEffect(() => {
callbackRef.current = callback;
}, [callback]);
useEffect(
function syncCallbackRef() {
callbackRef.current = callback;
},
[callback]
);

return useCallback((...args: Arguments) => {
return callbackRef.current(...args);
Expand Down