test(mobile): add missing SSR environment tests#346
Open
eunwoo-levi wants to merge 5 commits intotoss:mainfrom
Open
test(mobile): add missing SSR environment tests#346eunwoo-levi wants to merge 5 commits intotoss:mainfrom
eunwoo-levi wants to merge 5 commits intotoss:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Problem
4 hooks in
@react-simplikit/mobilewere missing.ssr.test.tsfiles, which are required by theproject's contributing guidelines for all hooks that access browser APIs.
Solution
Add SSR environment tests (
@vitest-environment node) for the 4 hooks, following the same patternas the existing SSR tests.
Hooks added in this PR
useNetworkStatususePageVisibilityuseAvoidKeyboarduseKeyboardHeightAdditional Fix
@vitest/coverage-v8was missing from@react-simplikit/mobiledevDependencies,while the coverage config already existed in
vitest.config.ts. Added the missing dependency.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?