feat(core/hooks): add 'useList' hook#341
Merged
kimyouknow merged 3 commits intotoss:mainfrom Mar 17, 2026
Merged
Conversation
kimyouknow
reviewed
Mar 13, 2026
| }); | ||
|
|
||
| const setAll = usePreservedCallback((values: T[]) => { | ||
| setList(values); |
Collaborator
There was a problem hiding this comment.
setAll passes the array reference directly (setList(values)) without copying, while useSet.setAll creates a new Set via new Set(values).
External mutations to the passed array could affect state. Non-blocking — just a consistency point.
kimyouknow
approved these changes
Mar 13, 2026
Collaborator
kimyouknow
left a comment
There was a problem hiding this comment.
Clean implementation! The action set (push/insertAt/updateAt/removeAt/setAll/reset) covers array operations well without over-abstracting.
Contributor
Author
|
@kimyouknow Same issue as #342 — the merge commit ( |
kimyouknow
added a commit
that referenced
this pull request
Mar 17, 2026
kimyouknow
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
useListhook for managing array state with stable action functions.Actions:
push,insertAt,updateAt,removeAt,setAll,resetChecklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?