Skip to content

chore: Remove peer dependency 'react-dom' from overlay-kit#219

Merged
jungpaeng merged 4 commits intotoss:mainfrom
minuukang:chore/remove-peer-react-dom
Feb 25, 2026
Merged

chore: Remove peer dependency 'react-dom' from overlay-kit#219
jungpaeng merged 4 commits intotoss:mainfrom
minuukang:chore/remove-peer-react-dom

Conversation

@minuukang
Copy link
Copy Markdown
Member

@minuukang minuukang commented Feb 25, 2026

Description

I'm using react native, but I can't use it because there's 'react-dom' in the peer dependency.

Remove 'react-dom' because it is not being used inside this package.

Related Issue: Fixes # (issue_number)

Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

Removed duplicate entry for 'react-dom' in peerDependencies.
Removed peer dependency for react-dom from yarn.lock.
Remove peer dependency on 'react-dom' from overlay-kit.
@minuukang minuukang requested a review from jungpaeng as a code owner February 25, 2026 15:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: b902ff5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
overlay-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 25, 2026

@minuukang is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.85%. Comparing base (6a96688) to head (b902ff5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          15       15           
  Lines        1340     1340           
  Branches      262      262           
=======================================
  Hits         1338     1338           
  Misses          2        2           
Components Coverage Δ
overlay-kit 99.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jungpaeng jungpaeng merged commit c6e3594 into toss:main Feb 25, 2026
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants