refactor: prevent useExternalEvents effect from running on every render#218
Open
eunwoo-levi wants to merge 2 commits intotoss:mainfrom
Open
refactor: prevent useExternalEvents effect from running on every render#218eunwoo-levi wants to merge 2 commits intotoss:mainfrom
eunwoo-levi wants to merge 2 commits intotoss:mainfrom
Conversation
|
|
@eunwoo-levi is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
handlersobject insideuseExternalEventsis recreated viaObject.entries().reduce()on every render. Since it is used as a dependency ofuseLayoutEffect, the effect runs on every render, causing unnecessaryemitter.off/emitter.oncycles.Changes
eventsin auseRefto always reference the latest callbacks without triggering re-registration.[]), which delegate toeventsRef.currentinternally.Motivation and Context
The previous implementation caused
emitter.off→emitter.onon every render, which is wasteful and creates a brief window where events could be missed between unsubscribe and resubscribe.How Has This Been Tested?
Types of changes
Checklist