Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,28 @@ jobs:
- id: test
name: Run Unit Tests
run: cargo test --tests --benches --examples --workspace --all-targets --all-features

- id: verify-test-isolation
name: Verify Test Isolation (data folder should be empty)
run: |
echo "Checking if data/ folder is polluted by tests..."
if [ -d "data" ]; then
FILE_COUNT=$(find data/ -mindepth 1 -type f | wc -l)
DIR_COUNT=$(find data/ -mindepth 1 -type d | wc -l)
echo "Files in data/: $FILE_COUNT"
echo "Subdirectories in data/: $DIR_COUNT"

if [ $FILE_COUNT -gt 0 ] || [ $DIR_COUNT -gt 0 ]; then
echo "❌ ERROR: Tests polluted the production data/ folder!"
echo "Contents of data/ folder:"
ls -laR data/
echo ""
echo "Tests must use temporary directories (TempWorkspace) with proper isolation."
echo "See docs/contributing/testing/ for best practices."
exit 1
else
echo "✅ Test isolation verified: data/ folder is clean"
fi
else
echo "✅ Test isolation verified: data/ folder does not exist"
fi
9 changes: 5 additions & 4 deletions docs/refactors/active-refactorings.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Active Refactoring Plans

| Document | Status | Issue | Target | Created |
| ----------------------------------------------------------------------------------------------------- | ----------- | ----- | ----------------------------------------- | ---------- |
| [Separate View Data from Views](plans/separate-view-data-from-views.md) | 📋 Planning | TBD | Organize presentation layer command views | 2026-02-16 |
| [Simplify Controller Command Handler Creation](plans/simplify-controller-command-handler-creation.md) | 📋 Planning | TBD | Remove unnecessary progress steps | 2025-12-17 |
| Document | Status | Issue | Target | Created |
| ----------------------------------------------------------------------------------------------------- | ----------- | ---------------------------------------------------------------------- | ----------------------------------------- | ---------- |
| [E2E Test Isolation - Complete Log Directory Support](plans/e2e-test-isolation-log-dir.md) | 📋 Planning | [#365](https://github.com/torrust/torrust-tracker-deployer/issues/365) | Add log_dir to all E2E tests | 2026-02-18 |
| [Separate View Data from Views](plans/separate-view-data-from-views.md) | 📋 Planning | TBD | Organize presentation layer command views | 2026-02-16 |
| [Simplify Controller Command Handler Creation](plans/simplify-controller-command-handler-creation.md) | 📋 Planning | TBD | Remove unnecessary progress steps | 2025-12-17 |
Loading
Loading