websocket_ping: fix ping interval with non-zero timeout and improve docs #3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oliver-sanders
commented
Jun 19, 2025
oliver-sanders
commented
- Fix a bug that caused the ping interval to be less frequent than configured.
- Fix erroneous documentation of the websocket_ping_timeout default and clarify units for the ping interval.
…ocs. * Fix a bug that caused the ping interval to be less frequent than configured. * Fix erroneous documentation of the websocket_ping_timeout default and clarify units for the ping interval.
oliver-sanders
commented
Jun 19, 2025
| @@ -1371,7 +1371,7 @@ async def periodic_ping(self) -> None: | |||
| return | |||
|
|
|||
| # wait until the next scheduled ping | |||
| await asyncio.sleep(IOLoop.current().time() - ping_time + interval) | |||
| await asyncio.sleep(ping_time + interval - IOLoop.current().time()) | |||
There was a problem hiding this comment.
Well this is embarrassing, the calculation of the next ping time was wrong, my apologies.
This caused pings to be less frequent than configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.