deps(deps): bump org.maplibre.gl:android-sdk from 12.3.1 to 13.0.2 - #754
deps(deps): bump org.maplibre.gl:android-sdk from 12.3.1 to 13.0.2#754dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [org.maplibre.gl:android-sdk](https://github.com/maplibre/maplibre-native) from 12.3.1 to 13.0.2. - [Release notes](https://github.com/maplibre/maplibre-native/releases) - [Changelog](https://github.com/maplibre/maplibre-native/blob/main/CHANGELOG.md) - [Commits](maplibre/maplibre-native@android-v12.3.1...android-v13.0.2) --- updated-dependencies: - dependency-name: org.maplibre.gl:android-sdk dependency-version: 13.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Greptile SummaryThis is a Dependabot-generated major-version bump of
Confidence Score: 3/5The upgrade switches the map rendering engine to Vulkan-only; on Android 7–9 devices without Vulkan drivers, the map will fail at runtime rather than degrade gracefully. The project's minSdk of 24 spans Android versions where Vulkan availability is not guaranteed. Any affected device will encounter a runtime map failure, not a compilation error, so the breakage may not surface in a standard build or emulator test run. The risk depends entirely on the actual device mix in production. app/build.gradle.kts — the single changed file; verifying whether the Vulkan-only artifact is appropriate for the supported device set is the key question before merging. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[App starts MapView] --> B{Device supports Vulkan?}
B -->|Yes| C[Vulkan renderer initializes ✅]
B -->|No - Android 7-9, some hardware| D[Runtime failure ❌]
C --> E[Map renders normally]
D --> F[Map view fails / crash]
G[Alternative: android-sdk-opengl:13.0.2] --> H[OpenGL ES renderer]
H --> I[Works on all minSdk 24 devices ✅]
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
app/build.gradle.kts:434
**Vulkan-only SDK may crash on Android 7–9 devices**
`android-v13.0.0` made Vulkan the exclusive rendering backend for the `org.maplibre.gl:android-sdk` artifact. The project's `minSdk` is 24 (Android 7.0), and Vulkan support is not guaranteed on all Android 7–9 devices — it depends on the device's hardware drivers and OEM choices (it only became mandatory in Android 10 with the CDD, and even then with exemptions). On devices where Vulkan is absent, the map view will fail to initialize at runtime rather than falling back silently.
If Vulkan device coverage is a concern, the alternative is `org.maplibre.gl:android-sdk-opengl:13.0.2`, which retains the OpenGL ES backend. If Vulkan-only is acceptable, it's worth verifying the supported device set against your analytics before merging.
Reviews (1): Last reviewed commit: "deps(deps): bump org.maplibre.gl:android..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| // MapLibre - for offline-capable maps | ||
| implementation("org.maplibre.gl:android-sdk:12.3.1") | ||
| implementation("org.maplibre.gl:android-sdk:13.0.2") |
There was a problem hiding this comment.
android-v13.0.0 made Vulkan the exclusive rendering backend for the org.maplibre.gl:android-sdk artifact. The project's minSdk is 24 (Android 7.0), and Vulkan support is not guaranteed on all Android 7–9 devices — it depends on the device's hardware drivers and OEM choices (it only became mandatory in Android 10 with the CDD, and even then with exemptions). On devices where Vulkan is absent, the map view will fail to initialize at runtime rather than falling back silently.
If Vulkan device coverage is a concern, the alternative is org.maplibre.gl:android-sdk-opengl:13.0.2, which retains the OpenGL ES backend. If Vulkan-only is acceptable, it's worth verifying the supported device set against your analytics before merging.
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/build.gradle.kts
Line: 434
Comment:
**Vulkan-only SDK may crash on Android 7–9 devices**
`android-v13.0.0` made Vulkan the exclusive rendering backend for the `org.maplibre.gl:android-sdk` artifact. The project's `minSdk` is 24 (Android 7.0), and Vulkan support is not guaranteed on all Android 7–9 devices — it depends on the device's hardware drivers and OEM choices (it only became mandatory in Android 10 with the CDD, and even then with exemptions). On devices where Vulkan is absent, the map view will fail to initialize at runtime rather than falling back silently.
If Vulkan device coverage is a concern, the alternative is `org.maplibre.gl:android-sdk-opengl:13.0.2`, which retains the OpenGL ES backend. If Vulkan-only is acceptable, it's worth verifying the supported device set against your analytics before merging.
How can I resolve this? If you propose a fix, please make it concise.
|
Superseded by #996. |
1 participant
Bumps org.maplibre.gl:android-sdk from 12.3.1 to 13.0.2.
Release notes
Sourced from org.maplibre.gl:android-sdk's releases.
Commits
6849681Release MapLibre Android 13.0.2 (#4201)b930be8Release MapLibre iOS 6.25.0 (#4200)d67e21dFix build issues iOS example app (#4199)53aa67cchore(deps): update dependency gradle to v8.14.4 (#4080)8188421Make sure MLNScaleBar is exported (#4198)d4bde4ccore: Use interleaved buffer for paint property binders (#4124)0aff90bBump js version to 6.4.1 (#4195)35cf39bcore: Fix crash during exception stack unwind (#4188)01cb5eblink mlt-cpp (#4183)00b748ccore: Fix vulkan surface rotation (#4182)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)