refactor(delivery): sealed DeliveryState + shared DeliveryRetryPolicy replace the stringly delivery contract

[torlando-tech]

The delivery status of an outbound LXMF message was an open set of magic
strings ("delivered", "failed", "retrying_propagated", ...) produced
independently by both backend flavors and hand-matched at 20+ consumer
sites across the app — and the try-propagation-on-fail retry logic behind
those strings was implemented twice (event_bridge.py and
NativeMessageSender), kept in sync only by "kept in lockstep" comments.
A typo or a new state added to one backend silently no-oped in the UI.

This PR lands both slices of the delivery-state deepening.

Slice 1 — typed seam (representation only, no behavior change)

• New sealed interface DeliveryState in :rns-api (Pending, Sent,
  Delivered, Propagated, RetryingViaPropagation, Failed) with the
  Issue Message delivery status logic issue. First it have a checkmark, but this checkmark changes to ! after some time passed #257 terminal-success policy as a property and an
  encode()/decode() codec pinning the legacy persistence strings.
• DeliveryStatusUpdate.status: String → state: DeliveryState. The
  parcelable crosses AIDL whole, so no marshalling changes.
• Both backend emit sites (PythonEventBridge, NativeMessageSender,
  NativeRnsBackendImpl) emit typed states.
• All app consumers (MessagingViewModel guards, MessageUi, MessageMapper,
  MessagingScreen, MessageDetailScreen, MessageCollector,
  ServicePersistenceManager, TestController) switch to exhaustive whens;
  isTerminalSuccessStatus in the ViewModel is replaced by
  DeliveryState.isTerminalSuccess.
• Room keeps storing the legacy strings (no migration); decode() is
  nullable for unrecognized legacy values, rendered as the historical
  else-branch presentation.

Slice 2 — shared retry decision (de-duplicates the Sideband pattern)

Planned as "a state machine in :rns-host", it landed as a decision/
mechanism split instead — the backends can't depend on :rns-host, and
the rebuild-and-resubmit mechanism must stay flavor-local because it
manipulates flavor-owned router/message objects:

• New DeliveryRetryPolicy in :rns-api — the one shared predicate
  ("retry via propagation iff opted in, not already PROPAGATED, node
  configured"), consulted by both flavors. A truth-table test pins the
  semantics, including the give-up-after-one-retry rule encoded by the
  desired-method flip.
• event_bridge.py loses the decision: _failed now only flattens the
  failure and parks the live LXMessage in an _outbound_messages
  registry; new mechanism-only resubmit_as_propagated /
  discard_outbound functions do the flavor-local surgery.
  reset_reticulum_for_restart clears the registry.
• PythonEventBridge.handleLxmfFailure applies the policy and drives the
  mechanism through an injected OutboundRetryMechanism hook wired in
  ChaquopyRnsBackend; the separate retrying-propagated event sink is
  gone.
• NativeMessageSender consults the same policy; its lxmf-kt rebuild
  mechanism is unchanged.

Docs & tests

• CONTEXT.md seeds the domain glossary: DeliveryState, DeliveryMethod,
  DeliveryRetryPolicy, propagation node, and the "propagated"
  method-vs-state trap.
• New DeliveryStateTest (codec + legacy decode) and
  DeliveryRetryPolicyTest (truth table); ParcelRoundTripTest covers
  every state across the AIDL boundary.

Verification

:rns-api, :rns-ipc, :rns-backend-kt, :rns-backend-py, and
:rns-host (kotlinBackend) unit tests green; the six affected :app
test classes pass (490 tests, 0 failures) with full :app main+test
compilation proving the exhaustiveness migration; event_bridge.py
py_compile clean. Not covered here: an on-device send-with-propagation-
node smoke test of the Python retry mechanism.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BZ3PvF8KzApTXFYTfabv1b

[greptile-apps]

Greptile Summary

This PR replaces delivery-status strings with a typed delivery-state contract. The main changes are:

• Added sealed DeliveryState values with legacy string encoding.
• Changed delivery updates to carry typed states across the API boundary.
• Updated backend emitters, retry handling, persistence bridges, and UI rendering.
• Added codec, parcel round-trip, and retry-policy tests.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.
• The typed API, persistence codec, backend emissions, and UI consumers remain aligned.
• Unknown legacy status values keep the intended neutral fallback behavior.

Important Files Changed

Filename	Overview
rns-api/src/main/java/network/columba/app/rns/api/model/DeliveryState.kt	Adds the closed delivery-state vocabulary and stable legacy string codec.
rns-api/src/main/java/network/columba/app/rns/api/model/DeliveryStatusUpdate.kt	Changes delivery updates from raw status strings to typed delivery states.
app/src/main/java/network/columba/app/viewmodel/MessagingViewModel.kt	Updates delivery guards, persistence writes, retry checks, and logging to use typed states.
app/src/main/java/network/columba/app/ui/model/MessageMapper.kt	Decodes persisted status strings into nullable UI delivery states.
app/src/main/java/network/columba/app/ui/screens/MessagingScreen.kt	Updates message status icons and failed-message actions to compare typed states.
app/src/main/java/network/columba/app/ui/screens/MessageDetailScreen.kt	Updates detail status and error rendering to use typed states with a legacy fallback.
rns-backend-py/src/main/kotlin/network/columba/app/rns/backend/py/PythonEventBridge.kt	Moves Python backend status translation and retry decisions onto typed delivery states.
rns-backend-py/src/main/python/event_bridge.py	Parks outbound messages for Kotlin-side retry decisions and exposes retry/discard hooks.
rns-backend-kt/src/main/kotlin/network/columba/app/rns/backend/kt/NativeMessageSender.kt	Updates native backend delivery emissions and retry checks to use shared typed state and policy.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Backend delivery callback] --> B[DeliveryStatusUpdate with DeliveryState]
  B --> C[MessagingViewModel]
  C --> D[Persist state.encode legacy string]
  D --> E[Room status column]
  E --> F[MessageMapper decodes status]
  F --> G[MessageUi DeliveryState?]
  G --> H[Compose status rendering]
  F --> I[Unknown legacy value]
  I --> J[Neutral fallback UI]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
  A[Backend delivery callback] --> B[DeliveryStatusUpdate with DeliveryState]
  B --> C[MessagingViewModel]
  C --> D[Persist state.encode legacy string]
  D --> E[Room status column]
  E --> F[MessageMapper decodes status]
  F --> G[MessageUi DeliveryState?]
  G --> H[Compose status rendering]
  F --> I[Unknown legacy value]
  I --> J[Neutral fallback UI]

Loading

_{Reviews (1): Last reviewed commit: "refactor(delivery): share the try-propag..." | Re-trigger Greptile}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!