Skip to content

ci: add unit test workflow #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torlando-tech merged 10 commits into from
Mar 27, 2026
Merged

ci: add unit test workflow #7

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
135bfbc
ci: add GitHub Actions workflow to run unit tests on PRs
torlando-tech Mar 27, 2026
3f7bbf2
ci: disable code signing for CI test builds
torlando-tech Mar 27, 2026
0362f96
ci: auto-detect Xcode version and simulator destination
torlando-tech Mar 27, 2026
2ec5425
ci: dynamically find available iPhone simulator for test runs
torlando-tech Mar 27, 2026
9cf36cf
ci: use ad-hoc signing for CI builds
torlando-tech Mar 27, 2026
b7fd2cd
ci: split into build-for-testing and test-without-building steps
torlando-tech Mar 27, 2026
514baaf
ci: add verbose build logging to diagnose ColumbaApp compilation failure
torlando-tech Mar 27, 2026
548553d
ci: explicitly build app target before running tests
torlando-tech Mar 27, 2026
308a400
ci: fix -target and -scheme conflict in build step
torlando-tech Mar 27, 2026
3c1ce4f
ci: build app with scheme first, then run tests separately
torlando-tech Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: Tests

on:
pull_request:
branches: [main]
push:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
test:
runs-on: macos-15
steps:
- uses: actions/checkout@v4

- name: Clone sibling packages
run: |
git clone https://github.com/torlando-tech/reticulum-swift.git ../reticulum-swift
git clone https://github.com/torlando-tech/LXMF-swift.git ../LXMF-swift
git clone https://github.com/torlando-tech/LXST-swift.git ../LXST-swift
Comment on lines +20 to +23
Copy link
Copy Markdown

@greptile-apps greptile-apps bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Sibling packages cloned at HEAD without pinning

The three sibling repos are cloned without specifying a branch, tag, or commit SHA, so every CI run always uses the latest HEAD of each package's default branch. If someone pushes a breaking change to reticulum-swift, LXMF-swift, or LXST-swift, this workflow will start failing even though nothing in columba-ios changed, making it hard to tell whether the failure is local or upstream.

Consider pinning to a specific branch or ref so the build is reproducible and failures are attributable:

git clone --branch main --single-branch https://github.com/torlando-tech/reticulum-swift.git ../reticulum-swift
git clone --branch main --single-branch https://github.com/torlando-tech/LXMF-swift.git ../LXMF-swift
git clone --branch main --single-branch https://github.com/torlando-tech/LXST-swift.git ../LXST-swift

Or, if full reproducibility is needed, add a step that resolves and records the HEAD SHAs of each sibling so failed runs can be replicated exactly.


- name: Select Xcode
run: |
XCODE=$(ls -d /Applications/Xcode_16*.app 2>/dev/null | sort -V | tail -1)
echo "Using $XCODE"
sudo xcode-select -s "$XCODE"
xcodebuild -version

- name: Find simulator
id: sim
run: |
DEVICE_ID=$(xcrun simctl list devices available -j \
| python3 -c "import sys,json; devs=json.load(sys.stdin)['devices']; print(next(d['udid'] for rt in devs for d in devs[rt] if 'iPhone' in d['name']))")
echo "device_id=$DEVICE_ID" >> "$GITHUB_OUTPUT"
echo "Using simulator: $DEVICE_ID"

- name: Build
run: |
xcodebuild build \
-project ColumbaApp.xcodeproj \
-scheme ColumbaApp \
-sdk iphonesimulator \
-destination "id=${{ steps.sim.outputs.device_id }}" \
CODE_SIGN_IDENTITY=- \
CODE_SIGNING_REQUIRED=NO \
CODE_SIGNING_ALLOWED=YES \
DEVELOPMENT_TEAM="" \
PROVISIONING_PROFILE_SPECIFIER=""

- name: Build and run tests
run: |
xcodebuild test \
-project ColumbaApp.xcodeproj \
-scheme ColumbaApp \
-sdk iphonesimulator \
-destination "id=${{ steps.sim.outputs.device_id }}" \
-only-testing:ColumbaAppTests \
-resultBundlePath TestResults.xcresult \
CODE_SIGN_IDENTITY=- \
CODE_SIGNING_REQUIRED=NO \
CODE_SIGNING_ALLOWED=YES \
DEVELOPMENT_TEAM="" \
PROVISIONING_PROFILE_SPECIFIER=""
Loading