Conversation
What was broken Newly registered identity-api-v6 users were created in Topcoder systems but were not automatically subscribed to the Topcoder newsletter in HubSpot. Root cause The v6 registration flow did not include a HubSpot contact or communication subscription side effect, and the archived identity service did not contain equivalent HubSpot newsletter logic to port. What was changed Added a non-fatal registration side effect that upserts the HubSpot contact and subscribes the registered email address to the configured Topcoder newsletter communication subscription. Documented the HubSpot configuration values required by identity-api-v6. Any added/updated tests Added a user service unit test covering the HubSpot contact upsert and newsletter subscription request payload for newly registered users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Newly registered identity-api-v6 users were created in Topcoder systems but were not automatically subscribed to the Topcoder newsletter in HubSpot.
Root cause
The v6 registration flow did not include a HubSpot contact or communication subscription side effect, and the archived identity service did not contain equivalent HubSpot newsletter logic to port.
What was changed
Added a non-fatal registration side effect that upserts the HubSpot contact and subscribes the registered email address to the configured Topcoder newsletter communication subscription.
Documented the HubSpot configuration values required by identity-api-v6.
Any added/updated tests
Added a user service unit test covering the HubSpot contact upsert and newsletter subscription request payload for newly registered users.
The focused HubSpot registration test passes. The full test suite was run and still fails on unrelated existing spec/type drift outside this PM-5114 change.