Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets performance improvements for Member API lookups (PM-4817, PM-3343) by reducing response payload size and standardizing request construction/timeout behavior.
Changes:
- Restrict Member API
/memberslookups to identity-only fields (userId,handle,email) and disable stats expansion. - Replace manual query-string building with
URLSearchParamsfor batched/single lookups. - Update the MemberApiService unit tests to reflect the new query parameters and timeout behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/shared/member-api/member-api.service.ts |
Adds request field filtering + includeStats=false, uses URLSearchParams, and introduces a request timeout fallback. |
src/shared/member-api/member-api.service.spec.ts |
Reworks tests to validate the new query string/timeout behavior and simplifies mocking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kkartunov
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance updates for PM-4817 and PM-3343
https://topcoder.atlassian.net/browse/PM-4817
https://topcoder.atlassian.net/browse/PM-3343