docs(examples): chain stops at first multi-key object#23
Closed
metalshark wants to merge 2 commits intotoon-format:mainfrom
Closed
docs(examples): chain stops at first multi-key object#23metalshark wants to merge 2 commits intotoon-format:mainfrom
metalshark wants to merge 2 commits intotoon-format:mainfrom
Conversation
Contributor
|
Thanks for catching this! The original examples didn't reflect the §13.4 "safe" key folding stop condition (folding must stop once an object has multiple keys). I've pushed an updated set of examples directly: b071a78
Closing this as fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Section 13.4 Key Folding and Path Expansion
Encoder: Key Folding
Chain stops at first multi-key object
These examples however do not stop chaining at the first multi-key object.
Type of Change
Motivation and Context
This changes examples to comply with the specification.
Changes Made
Fixed chaining and indentation.
Specification Sections Affected
Backward Compatibility
Impact on Existing Implementations
Test Coverage
Documentation
Checklist