zig support #214
Draft
zig support #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
tonistiigi
reviewed
Sep 12, 2025
| if command -v "$XX_TRIPLE-pkg-config" >/dev/null 2>/dev/null; then | ||
| export PKG_CONFIG="$XX_TRIPLE-pkg-config" | ||
| pkgconfig_set=1 | ||
| if command -v "zig" >/dev/null 2>/dev/null; then |
Owner
There was a problem hiding this comment.
I'm not sure we should replace CC with zig just because it is installed. I guess this would be ok if there is no clang and gcc installed. Otherwise I would expect some opt-in env.
Collaborator
Author
Yes will add tests
Hum yes might make sense for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.