Adds a slurp mode for reading the full file#91
Open
rjp wants to merge 1 commit intotomnomnom:masterfrom
Open
Conversation
Using the slurp option -- `-S`, `-slurp` -- causes gron to read *all* the data into RAM before processing. Tested on a 102M JSON file - memory usage is about 400M for parsing the first object. Fixes tomnomnom#70 (in a fairly sledgehammer way, I suppose.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the slurp option --
-S,-slurp-- causes gron to read all thedata into RAM before processing. Tested on a 102M JSON file - memory
usage is about 400M for parsing the first object.
Fixes #70 (in a fairly sledgehammer way, I suppose, but it's easier for
people to deal with "read the whole file" than try to guess a number for
a buffer size, especially if you don't know the file size in advance.)
Tests pass but linting doesn't but then agan linting also doesn't pass on
the unmodified master either because
gometalintis broken these days.